Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Add missing css template tags #80385

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Nov 7, 2024

in order to enable minification, linting, etc the css fragments have to be tagged

in order to enable minification, linting, etc the css fragments have to be tagged
@scttcper scttcper requested a review from a team November 7, 2024 18:31
@scttcper scttcper requested review from a team as code owners November 7, 2024 18:31
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 7, 2024
`
: null}
${p =>
p.highlightedSliceName
? `
--defaultSlice-opacity: 1.0;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm it did this automatically

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't know what to do before since it wasn't in the tagged template

Copy link

codecov bot commented Nov 7, 2024

Bundle Report

Changes will increase total bundle size by 11.05kB (0.03%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 31.9MB 11.05kB (0.03%) ⬆️

@scttcper scttcper enabled auto-merge (squash) November 7, 2024 18:43
@scttcper scttcper merged commit d2869af into master Nov 7, 2024
43 of 44 checks passed
@scttcper scttcper deleted the scttcper/missing-css-fragment branch November 7, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants