feat(crons): Skip marking unknowns as failures #80347
Open
+60
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files@@ Coverage Diff @@
## master #80347 +/- ##
==========================================
+ Coverage 76.34% 78.34% +1.99%
==========================================
Files 7191 7190 -1
Lines 318149 318142 -7
Branches 43856 43857 +1
==========================================
+ Hits 242896 249250 +6354
+ Misses 68584 62533 -6051
+ Partials 6669 6359 -310 |
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-skip-marking-unknowns-as-failures
branch
from
b2dd7bb
to
9f759c4
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-skip-marking-unknowns-as-failures
branch
from
9f759c4
to
0b83dd0
Compare
JoshFerge
reviewed
Nov 7, 2024
| @@ -55,7 +56,7 @@ def mark_failed( | |||
|
|
|||
| # When the failed check-in is a synthetic missed check-in we do not move | |||
| # the `last_checkin` timestamp forward. | |||
| if failed_checkin.status == CheckInStatus.MISSED: | |||
| if is_miss: | |||
There was a problem hiding this comment.
i'm kind of confused why we need this boolean instead of relying on the checkin status
There was a problem hiding this comment.
Because the check-in status will be UNKNOWN in the future
JoshFerge
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an UNKNOWN check-in is processed through
mark_failuredo NOT produce an issue occurance or do any incident creation.This will be used by mark_missing to produce UNKNOWN check-ins during a possible data-loss incident, but not notify the user that their monitor was missed.
Part of GH-79328