Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(billing): Iterate through categories for quota notifs FE #80037

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

@isabellaenriquez isabellaenriquez requested a review from a team as a code owner October 30, 2024 23:06
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 30, 2024
@isabellaenriquez isabellaenriquez requested a review from a team October 30, 2024 23:06
@@ -147,7 +147,7 @@ describe('NotificationSettingsByType', function () {
expect(projectsMock).toHaveBeenCalledTimes(1);
});

it('renders all the quota subcatories', async function () {
it('renders all the quota subcategories', async function () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for fixing typo

@isabellaenriquez isabellaenriquez merged commit 9c5bfff into master Nov 7, 2024
44 checks passed
@isabellaenriquez isabellaenriquez deleted the isabella/iterate-notifs-fe branch November 7, 2024 19:15
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #80037      +/-   ##
==========================================
- Coverage   78.31%   78.26%   -0.06%     
==========================================
  Files        7192     7180      -12     
  Lines      318363   316564    -1799     
  Branches    43885    43637     -248     
==========================================
- Hits       249337   247754    -1583     
+ Misses      62670    62507     -163     
+ Partials     6356     6303      -53     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants