Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crons): Add TickVolumeAnomolyResult #79715

Merged

Conversation

evanpurkhiser
Copy link
Member

This will be used to pass around the result of anomaly detection during
clock ticks.

Part of #79328

This will be used to pass around the result of anomaly detection during
clock ticks.

Part of #79328
@evanpurkhiser evanpurkhiser requested a review from a team as a code owner October 24, 2024 19:55
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/monitors/types.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #79715       +/-   ##
===========================================
+ Coverage   52.40%   78.45%   +26.05%     
===========================================
  Files        7120     7146       +26     
  Lines      314736   316049     +1313     
  Branches    43323    43490      +167     
===========================================
+ Hits       164930   247969    +83039     
+ Misses     148268    61738    -86530     
- Partials     1538     6342     +4804     

Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth adding a quick unit test?

@evanpurkhiser
Copy link
Member Author

worth adding a quick unit test?

This should be covered by other test cases, I think it's OK

@evanpurkhiser evanpurkhiser merged commit 0fc47b1 into master Oct 24, 2024
50 of 51 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/feat-crons-add-tickvolumeanomolyresult branch October 24, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants