Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): Add an option to extrapolate tx and span metrics #73911

Merged
merged 6 commits into from
Jul 9, 2024

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Jul 8, 2024

Adds a global option to include the transactions and spans namespaces in
metrics extrapolation, when the respective organization- or project option are
enabled.

Billing usage metrics and the dynamic sampling metric count_per_root_project
are explicitly excluded, since those require actual ingested numbers instead of
extrapolated numbers.

Epic: getsentry/relay#3724

TODOs:

  • Add a test (requires librelay 0.9.0 released)
  • Check for more metrics needed by dynamic sampling

@jan-auer jan-auer requested a review from a team as a code owner July 8, 2024 08:32
@jan-auer jan-auer self-assigned this Jul 8, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.10%. Comparing base (5ac86dc) to head (00e17ac).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #73911    +/-   ##
========================================
  Coverage   78.10%   78.10%            
========================================
  Files        6660     6665     +5     
  Lines      297718   297586   -132     
  Branches    51232    51199    -33     
========================================
- Hits       232546   232444   -102     
+ Misses      58902    58871    -31     
- Partials     6270     6271     +1     
Files Coverage Δ
src/sentry/options/defaults.py 100.00% <100.00%> (ø)
src/sentry/relay/config/metric_extraction.py 87.47% <0.00%> (-1.28%) ⬇️

... and 77 files with indirect coverage changes

@jan-auer jan-auer enabled auto-merge (squash) July 9, 2024 08:26
@jan-auer jan-auer merged commit 3f15b93 into master Jul 9, 2024
51 checks passed
@jan-auer jan-auer deleted the feat/extrapolate-tx-spans branch July 9, 2024 08:46
priscilawebdev pushed a commit that referenced this pull request Jul 11, 2024
Adds a global option to include the `transactions` and `spans`
namespaces in metrics extrapolation, when the respective organization-
or project option are enabled.

Billing usage metrics and the dynamic sampling metric
`count_per_root_project` are explicitly excluded, since those require
actual ingested numbers instead of extrapolated numbers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants