-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): Add an option to extrapolate tx and span metrics #73911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obostjancic
approved these changes
Jul 8, 2024
vgrozdanic
approved these changes
Jul 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #73911 +/- ##
========================================
Coverage 78.10% 78.10%
========================================
Files 6660 6665 +5
Lines 297718 297586 -132
Branches 51232 51199 -33
========================================
- Hits 232546 232444 -102
+ Misses 58902 58871 -31
- Partials 6270 6271 +1
|
priscilawebdev
pushed a commit
that referenced
this pull request
Jul 11, 2024
Adds a global option to include the `transactions` and `spans` namespaces in metrics extrapolation, when the respective organization- or project option are enabled. Billing usage metrics and the dynamic sampling metric `count_per_root_project` are explicitly excluded, since those require actual ingested numbers instead of extrapolated numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a global option to include the
transactions
andspans
namespaces inmetrics extrapolation, when the respective organization- or project option are
enabled.
Billing usage metrics and the dynamic sampling metric
count_per_root_project
are explicitly excluded, since those require actual ingested numbers instead of
extrapolated numbers.
Epic: getsentry/relay#3724
TODOs: