-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(slack): move some floating functions into SlackService #73695
Open
cathteng
wants to merge
6
commits into
master
Choose a base branch
from
cathy/slack/move-floating-functions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Automatically applied to PRs that change backend components
label
Jul 2, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #73695 +/- ##
===========================================
+ Coverage 56.99% 78.12% +21.13%
===========================================
Files 6642 6651 +9
Lines 297290 297594 +304
Branches 51155 51204 +49
===========================================
+ Hits 169446 232506 +63060
+ Misses 123101 58777 -64324
- Partials 4743 6311 +1568
|
cathteng
force-pushed
the
cathy/slack/move-floating-functions
branch
from
July 3, 2024 16:26
9836883
to
31c972e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
_get_attachments
,_notify_recipient
, and_send_message_to_slack_channel
under SlackService, which were previously floating functions. We should centralize Slack logic where possible.Also fixes typing for
SlackBlock
andSlackAttachment
(which are literally the same thing), we should be usingdict
since we're mutating the result inget_attachments
(typing is enforced in its home).