feat(trace-explorer): Render list of trace related project icons #73691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of always rendering a single project icon for the trace root, render a list of project icons for all related projects in the trace. We try to prioritize projects that are selected in order to avoid users thinking it's making a cross project query.
github-actions
bot
added
the
Scope: Frontend
Zylphrex
commented
Jul 2, 2024
| maxVisibleProjects?: number; | ||
| } | ||
|
|
||
| export function ProjectsRenderer({ |
There was a problem hiding this comment.
This was largely adapted from AvatarList however that component is very much specialized right now and doesn't extend to this use case very well. A good place to clean up in the future.
Bundle ReportChanges will increase total bundle size by 2.82kB ⬆️
|
…render-list-of-trace-related-project-icons
k-fish
approved these changes
Jul 4, 2024
Comment on lines
+844
to
+850
| grid-template-columns: 116px auto repeat(2, min-content) 85px 112px 66px; | ||
| `; | ||
|
|
||
| const SpanPanelContent = styled('div')` | ||
| width: 100%; | ||
| display: grid; | ||
| grid-template-columns: repeat(1, min-content) auto repeat(1, min-content) 160px 85px; | ||
| grid-template-columns: 100px auto repeat(1, min-content) 160px 85px; |
There was a problem hiding this comment.
we dont use a monospace font for the id so depending on the id, the trace/span id could end up with different widths using min-content
There was a problem hiding this comment.
Ah now you say it I did notice that
…render-list-of-trace-related-project-icons
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #73691 +/- ##
==========================================
+ Coverage 78.11% 78.12% +0.01%
==========================================
Files 6659 6659
Lines 297962 298009 +47
Branches 51266 51270 +4
==========================================
+ Hits 232752 232825 +73
+ Misses 58920 58895 -25
+ Partials 6290 6289 -1
|
Zylphrex
deleted the
txiao/feat/render-list-of-trace-related-project-icons
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of always rendering a single project icon for the trace root, render a list of project icons for all related projects in the trace. We try to prioritize projects that are selected in order to avoid users thinking it's making a cross project query.
Screenshot