feat(nuxt): Add sdk module to nuxt config and create client and server config files #713
+518
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
andreiborza
commented
Nov 21, 2024
Comment on lines
+90
to
+98
| await traceStep('configure-sdk', async () => { | ||
| await addSDKModule(nuxtConfig, { | ||
| org: selectedProject.organization.slug, | ||
| project: selectedProject.slug, | ||
| url: selfHosted ? sentryUrl : undefined, | ||
| }); | ||
|
|
||
| await createConfigFiles(selectedProject.keys[0].dsn.public); | ||
| }); |
There was a problem hiding this comment.
q: I handle error handling within the respective helpers. Would it be better to throw and wrap traceStep in a try catch?
andreiborza
requested review from
Lms24
and removed request for
AbhiPrasad and
mydea
lforst
reviewed
Nov 21, 2024
|
|
||
| shouldWriteFile = overwriteExistingConfigs; | ||
|
|
||
| if (overwriteExistingConfigs) { |
There was a problem hiding this comment.
If the user selects "no" when asked to overwrite, we should still show them what they would need to put in those files.
lforst
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested locally on a nuxt app with various configs. The nuxt default config is taken directly from the latest nuxt version when creating a basic project using their wizard.
#skip-changelog
Closes: #707 and #708