-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Building playbackengine #622
Draft
bitsandfoxes
wants to merge
4
commits into
main
Choose a base branch
from
feat/build-playbackengine
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule sentry-native
updated
83 files
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 0 additions & 35 deletions
35
src/Sentry.Unity.Editor/ConfigurationWindow/DebugSymbolsTab.cs
This file was deleted.
Oops, something went wrong.
54 changes: 54 additions & 0 deletions
54
src/Sentry.Unity.Editor/ConfigurationWindow/EditorOptions.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
using UnityEditor; | ||
using UnityEngine; | ||
|
||
namespace Sentry.Unity.Editor.ConfigurationWindow | ||
{ | ||
internal static class EditorOptions | ||
{ | ||
internal static void Display(SentryEditorOptions editorOptions) | ||
{ | ||
editorOptions.UploadSymbols = EditorGUILayout.BeginToggleGroup( | ||
new GUIContent("Upload Symbols", "Whether debug symbols should be uploaded automatically " + | ||
"on release builds."), | ||
editorOptions.UploadSymbols); | ||
|
||
editorOptions.UploadDevelopmentSymbols = EditorGUILayout.Toggle( | ||
new GUIContent("Upload Dev Symbols", "Whether debug symbols should be uploaded automatically " + | ||
"on development builds."), | ||
editorOptions.UploadDevelopmentSymbols); | ||
|
||
EditorGUILayout.EndToggleGroup(); | ||
|
||
editorOptions.Auth = EditorGUILayout.TextField( | ||
new GUIContent("Auth Token", "The authorization token from your user settings in Sentry"), | ||
editorOptions.Auth); | ||
|
||
editorOptions.Organization = EditorGUILayout.TextField( | ||
new GUIContent("Org Slug", "The organization slug in Sentry"), | ||
editorOptions.Organization); | ||
|
||
editorOptions.Project = EditorGUILayout.TextField( | ||
new GUIContent("Project Name", "The project name in Sentry"), | ||
editorOptions.Project); | ||
|
||
EditorGUILayout.Space(); | ||
EditorGUI.DrawRect(EditorGUILayout.GetControlRect(false, 1), Color.gray); | ||
EditorGUILayout.Space(); | ||
|
||
editorOptions.AddSentryToWindowsPlayer = EditorGUILayout.Toggle( | ||
new GUIContent("Add Sentry to Windows Player", "If enabled the SDK will " + | ||
"compile the Windows Player from source and add Sentry to it."), | ||
editorOptions.AddSentryToWindowsPlayer); | ||
|
||
editorOptions.MSBuildPath = EditorGUILayout.TextField( | ||
new GUIContent("MSBuild Path", "The path to MSBuild, if left empty the SDK will " + | ||
"try to locate it."), | ||
editorOptions.MSBuildPath); | ||
|
||
editorOptions.VSWherePath = EditorGUILayout.TextField( | ||
new GUIContent("VSWhere Path", "The path to VSWhere used to locate MSBuild. If " + | ||
"left empty the SDK will try to locate it."), | ||
editorOptions.VSWherePath); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
using System.IO; | ||
using Sentry.Extensibility; | ||
using UnityEditor; | ||
|
||
namespace Sentry.Unity.Editor | ||
{ | ||
internal static class EditorFileIO | ||
{ | ||
internal static void CopyDirectory(string sourcePath, string targetPath, IDiagnosticLogger? logger) | ||
{ | ||
if (Directory.Exists(targetPath)) | ||
{ | ||
logger?.LogDebug("'{0}' already already exists.", targetPath); | ||
return; | ||
} | ||
|
||
if (Directory.Exists(sourcePath)) | ||
{ | ||
logger?.LogDebug("Copying from: '{0}' to '{1}'", sourcePath, targetPath); | ||
|
||
Directory.CreateDirectory(Path.Combine(Path.GetDirectoryName(targetPath))); | ||
FileUtil.CopyFileOrDirectory(sourcePath, targetPath); | ||
} | ||
} | ||
|
||
internal static void CopyFile(string sourcePath, string targetPath, IDiagnosticLogger? logger) | ||
{ | ||
if (File.Exists(targetPath)) | ||
{ | ||
logger?.LogDebug("'{0}' has already been copied to '{1}'", Path.GetFileName(targetPath), targetPath); | ||
return; | ||
} | ||
|
||
if (File.Exists(sourcePath)) | ||
{ | ||
logger?.LogDebug("Copying from: '{0}' to '{1}'", sourcePath, targetPath); | ||
|
||
Directory.CreateDirectory(Path.Combine(Path.GetDirectoryName(targetPath))); | ||
FileUtil.CopyFileOrDirectory(sourcePath, targetPath); | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
using UnityEditor; | ||
|
||
namespace Sentry.Unity.Editor | ||
{ | ||
internal interface IEditorApplication | ||
{ | ||
string ApplicationContentsPath { get; } | ||
} | ||
|
||
internal sealed class EditorApplicationAdapter : IEditorApplication | ||
{ | ||
public static readonly EditorApplicationAdapter Instance = new(); | ||
|
||
public string ApplicationContentsPath => EditorApplication.applicationContentsPath; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.