chore(deps): Bumps sample app to RN 0.76.3 #4207

antonis · 2024-10-25T10:50:55Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Bumps sample app to RN 0.76.3

Refs:

💡 Motivation and Context

RN 0.76.0 release

Fix #4188

💚 How did you test it?

Manual Testing with the sample apps, CI
Verify that the Android app does not crash with profiling enabled

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

samples/react-native/package.json

github-actions · 2024-10-28T07:51:58Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1225.75 ms	1228.88 ms	3.13 ms
Size	2.36 MiB	3.10 MiB	753.53 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`77680ec`+dirty	1231.81 ms	1238.35 ms	6.54 ms
`1faf8e3`+dirty	1214.87 ms	1222.83 ms	7.97 ms
`7bc4d75`+dirty	1233.40 ms	1229.56 ms	-3.83 ms
`d7401ac`+dirty	1252.38 ms	1275.04 ms	22.66 ms
`8ae23a7`+dirty	1230.02 ms	1227.62 ms	-2.40 ms
`5a22220`+dirty	1209.49 ms	1220.94 ms	11.45 ms
`80b2ce3`+dirty	1265.92 ms	1268.60 ms	2.69 ms
`b95b8af`+dirty	1221.39 ms	1228.52 ms	7.13 ms
`d0bf494`+dirty	1289.40 ms	1298.40 ms	9.00 ms
`f06c879`+dirty	1252.64 ms	1259.66 ms	7.02 ms

App size

Revision	Plain	With Sentry	Diff
`77680ec`+dirty	2.36 MiB	3.10 MiB	753.42 KiB
`1faf8e3`+dirty	2.36 MiB	3.08 MiB	736.75 KiB
`7bc4d75`+dirty	2.36 MiB	3.10 MiB	752.58 KiB
`d7401ac`+dirty	2.36 MiB	2.83 MiB	481.14 KiB
`8ae23a7`+dirty	2.36 MiB	3.10 MiB	752.42 KiB
`5a22220`+dirty	2.36 MiB	2.92 MiB	570.21 KiB
`80b2ce3`+dirty	2.36 MiB	2.84 MiB	486.98 KiB
`b95b8af`+dirty	2.36 MiB	3.14 MiB	793.32 KiB
`d0bf494`+dirty	2.36 MiB	2.83 MiB	481.15 KiB
`f06c879`+dirty	2.36 MiB	2.88 MiB	530.42 KiB

Previous results on branch: antonis/chore-samples-rn0.76.0

Startup times

Revision	Plain	With Sentry	Diff
`e6a2b88`+dirty	1221.27 ms	1222.12 ms	0.86 ms
`be4394d`+dirty	1228.31 ms	1228.27 ms	-0.04 ms
`0a5baa3`+dirty	1217.31 ms	1218.64 ms	1.33 ms

App size

Revision	Plain	With Sentry	Diff
`e6a2b88`+dirty	2.36 MiB	3.08 MiB	735.59 KiB
`be4394d`+dirty	2.36 MiB	3.10 MiB	752.34 KiB
`0a5baa3`+dirty	2.36 MiB	3.10 MiB	753.42 KiB

github-actions · 2024-10-28T07:54:47Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	406.94 ms	453.82 ms	46.88 ms
Size	7.15 MiB	8.36 MiB	1.21 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`7fd512a`+dirty	439.69 ms	503.71 ms	64.01 ms
`0d3e677`+dirty	384.24 ms	431.45 ms	47.21 ms
`15c80ab`+dirty	276.38 ms	327.54 ms	51.17 ms
`0db0c72`+dirty	335.20 ms	351.06 ms	15.86 ms
`e2b64fe`+dirty	258.82 ms	304.26 ms	45.44 ms
`1c65324`+dirty	381.10 ms	427.26 ms	46.16 ms
`5a22220`+dirty	384.61 ms	419.06 ms	34.45 ms
`728164b`+dirty	335.93 ms	342.94 ms	7.01 ms
`62a750b`+dirty	370.78 ms	376.73 ms	5.96 ms
`c398f67`+dirty	315.08 ms	345.60 ms	30.52 ms

App size

Revision	Plain	With Sentry	Diff
`7fd512a`+dirty	7.15 MiB	8.35 MiB	1.21 MiB
`0d3e677`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`15c80ab`+dirty	7.15 MiB	8.09 MiB	966.13 KiB
`0db0c72`+dirty	7.15 MiB	8.04 MiB	911.02 KiB
`e2b64fe`+dirty	7.15 MiB	8.07 MiB	947.16 KiB
`1c65324`+dirty	7.15 MiB	8.22 MiB	1.07 MiB
`5a22220`+dirty	7.15 MiB	8.21 MiB	1.06 MiB
`728164b`+dirty	7.15 MiB	8.12 MiB	997.71 KiB
`62a750b`+dirty	7.15 MiB	8.21 MiB	1.06 MiB
`c398f67`+dirty	7.15 MiB	8.21 MiB	1.07 MiB

Previous results on branch: antonis/chore-samples-rn0.76.0

Startup times

Revision	Plain	With Sentry	Diff
`0a5baa3`+dirty	395.98 ms	439.29 ms	43.31 ms
`be4394d`+dirty	269.00 ms	322.83 ms	53.83 ms
`e6a2b88`+dirty	402.42 ms	470.18 ms	67.76 ms

App size

Revision	Plain	With Sentry	Diff
`0a5baa3`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`be4394d`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`e6a2b88`+dirty	7.15 MiB	8.35 MiB	1.20 MiB

github-actions · 2024-10-28T07:56:23Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1245.29 ms	1245.19 ms	-0.10 ms
Size	2.92 MiB	3.66 MiB	758.74 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`77680ec`+dirty	1237.65 ms	1236.24 ms	-1.41 ms
`1faf8e3`+dirty	1223.38 ms	1220.56 ms	-2.82 ms
`7bc4d75`+dirty	1222.13 ms	1216.39 ms	-5.74 ms
`d7401ac`+dirty	1288.10 ms	1289.54 ms	1.44 ms
`8ae23a7`+dirty	1233.67 ms	1229.52 ms	-4.15 ms
`5a22220`+dirty	1246.18 ms	1249.61 ms	3.43 ms
`80b2ce3`+dirty	1245.12 ms	1262.04 ms	16.92 ms
`b95b8af`+dirty	1235.60 ms	1242.06 ms	6.46 ms
`d0bf494`+dirty	1266.20 ms	1267.52 ms	1.32 ms
`f06c879`+dirty	1285.14 ms	1285.86 ms	0.72 ms

App size

Revision	Plain	With Sentry	Diff
`77680ec`+dirty	2.92 MiB	3.66 MiB	758.54 KiB
`1faf8e3`+dirty	2.92 MiB	3.64 MiB	742.61 KiB
`7bc4d75`+dirty	2.92 MiB	3.66 MiB	757.15 KiB
`d7401ac`+dirty	2.92 MiB	3.40 MiB	488.06 KiB
`8ae23a7`+dirty	2.92 MiB	3.66 MiB	757.67 KiB
`5a22220`+dirty	2.92 MiB	3.48 MiB	575.81 KiB
`80b2ce3`+dirty	2.92 MiB	3.40 MiB	492.75 KiB
`b95b8af`+dirty	2.92 MiB	3.69 MiB	794.16 KiB
`d0bf494`+dirty	2.92 MiB	3.40 MiB	488.08 KiB
`f06c879`+dirty	2.92 MiB	3.44 MiB	533.24 KiB

Previous results on branch: antonis/chore-samples-rn0.76.0

Startup times

Revision	Plain	With Sentry	Diff
`e6a2b88`+dirty	1252.67 ms	1252.24 ms	-0.43 ms
`be4394d`+dirty	1230.27 ms	1226.51 ms	-3.76 ms
`0a5baa3`+dirty	1247.31 ms	1240.88 ms	-6.43 ms

App size

Revision	Plain	With Sentry	Diff
`e6a2b88`+dirty	2.92 MiB	3.64 MiB	741.24 KiB
`be4394d`+dirty	2.92 MiB	3.66 MiB	756.68 KiB
`0a5baa3`+dirty	2.92 MiB	3.66 MiB	758.62 KiB

github-actions · 2024-10-28T08:09:07Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	482.75 ms	479.71 ms	-3.04 ms
Size	17.74 MiB	20.08 MiB	2.35 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`5446992`	403.40 ms	426.70 ms	23.30 ms
`700cbf4`	425.56 ms	436.26 ms	10.70 ms
`15c80ab`+dirty	336.27 ms	350.58 ms	14.31 ms
`8ae23a7`	526.83 ms	513.38 ms	-13.45 ms
`12427f4`	393.69 ms	414.84 ms	21.14 ms
`e1ea4a8`	506.82 ms	510.48 ms	3.66 ms
`e5c9b8b`	409.02 ms	426.66 ms	17.64 ms
`5571a20`	410.55 ms	441.06 ms	30.51 ms
`fe13591`	478.92 ms	480.84 ms	1.92 ms
`9c48b2c`	349.24 ms	385.96 ms	36.72 ms

App size

Revision	Plain	With Sentry	Diff
`5446992`	17.73 MiB	19.85 MiB	2.12 MiB
`700cbf4`	17.73 MiB	20.07 MiB	2.33 MiB
`15c80ab`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`8ae23a7`	17.74 MiB	20.07 MiB	2.34 MiB
`12427f4`	17.73 MiB	19.85 MiB	2.12 MiB
`e1ea4a8`	17.74 MiB	20.08 MiB	2.34 MiB
`e5c9b8b`	17.73 MiB	19.83 MiB	2.10 MiB
`5571a20`	17.73 MiB	19.93 MiB	2.19 MiB
`fe13591`	17.74 MiB	20.07 MiB	2.34 MiB
`9c48b2c`	17.73 MiB	19.80 MiB	2.07 MiB

Previous results on branch: antonis/chore-samples-rn0.76.0

Startup times

Revision	Plain	With Sentry	Diff
`be4394d`	420.09 ms	416.15 ms	-3.95 ms
`e6a2b88`	648.02 ms	633.98 ms	-14.04 ms
`0a5baa3`	440.08 ms	443.42 ms	3.34 ms

App size

Revision	Plain	With Sentry	Diff
`be4394d`	17.74 MiB	20.08 MiB	2.34 MiB
`e6a2b88`	17.74 MiB	20.08 MiB	2.34 MiB
`0a5baa3`	17.74 MiB	20.08 MiB	2.34 MiB

krystofwoldrich · 2024-11-07T12:34:30Z

(NOBRIDGE) ERROR ReferenceError: An error was thrown when attempting to render log messages via LogBox.
Property 'setImmediate' doesn't exist

It this still an issue?

antonis · 2024-11-07T12:40:15Z

(NOBRIDGE) ERROR ReferenceError: An error was thrown when attempting to render log messages via LogBox.
Property 'setImmediate' doesn't exist
It this still an issue?

@krystofwoldrich yes. The iOS sample compiles successfully and the error occurs on load preventing the app from loading. I guess this is some dependency issue but I haven't figured out a solution yet. Any suggestions are welcome 🙇

# Conflicts: # samples/react-native/android/app/src/main/jni/OnLoad.cpp # samples/react-native/ios/sentryreactnativesample/AppDelegate.mm # samples/react-native/package.json # yarn.lock

# Conflicts: # samples/react-native/package.json

This reverts commit c5c8f76.

# Conflicts: # yarn.lock

# Conflicts: # samples/react-native/package.json

samples/react-native/src/App.tsx

krystofwoldrich · 2024-11-22T11:31:24Z

samples/react-native/tm/NativePlatformSampleModule.ts


 export interface Spec extends TurboModule {
  crashOrString(): string;
 }

-export default TurboModuleRegistry.get<Spec>('NativePlatformSampleModule');
+export default TurboModuleRegistry.getEnforcing<Spec>('NativePlatformSampleModule');


We used non enforcing get to ensure the application works also with the Legacy architecture. This will break that.

Thank you for the context @krystofwoldrich
Reverted with db06022

krystofwoldrich · 2024-11-22T11:32:53Z

Over all the PR good, thank you for keeping the sample up to date, I just have two questions I want to resolve before approving it.

krystofwoldrich · 2024-11-22T11:57:44Z

The missing setImmediate might be related to the Promises patch the SDK automatically applies. My guess is the error will go away when the Promise patch is disabled.

antonis · 2024-11-22T12:14:50Z

The missing setImmediate might be related to the Promises patch the SDK automatically applies. My guess is the error will go away when the Promise patch is disabled.

Thank you for pointing me to this @krystofwoldrich 🙇

I've tried with the patchGlobalPromise hardcoded to false and the error persists 🤔

Upgrades sample app to RN 0.76.0

ebb7d98

antonis commented Oct 25, 2024

View reviewed changes

samples/react-native/package.json Show resolved Hide resolved

antonis commented Oct 25, 2024

View reviewed changes

samples/react-native/package.json Outdated Show resolved Hide resolved

antonis commented Oct 25, 2024

View reviewed changes

samples/react-native/package.json Outdated Show resolved Hide resolved

Add react-native-safe-area-context with commit reference

f3c875f

antonis commented Oct 25, 2024

View reviewed changes

samples/react-native/package.json Outdated Show resolved Hide resolved

Updates react-native-safe-area-context to 4.12.0

f92c67e

antonis added 4 commits October 28, 2024 12:35

Use latest stable version of react-native-screens

adb744d

Update react-navigation libraries

0a06263

Set react-native-community/cli version to 15.0.0

45e2faf

Merge branch 'main' into antonis/chore-samples-rn0.76.0

295af6c

antonis changed the title ~~chore(deps): Bumps sample app to RN 0.76.0~~ chore(deps): Bumps sample app to RN 0.76.1 Oct 30, 2024

antonis added 4 commits October 30, 2024 12:23

Upgrade ro RN0.76.1

a5f536f

Updates Gemfile

cf617f4

Merge branch 'main' into antonis/chore-samples-rn0.76.0

a6ebb8b

Merge branch 'main' into antonis/chore-samples-rn0.76.0

a68db6c

antonis added 8 commits November 7, 2024 15:04

Merge branch 'main' into antonis/chore-samples-rn0.76.0

a731fa4

# Conflicts: # samples/react-native/android/app/src/main/jni/OnLoad.cpp # samples/react-native/ios/sentryreactnativesample/AppDelegate.mm # samples/react-native/package.json # yarn.lock

Merge branch 'main' into antonis/chore-samples-rn0.76.0

4379135

Merge branch 'main' into antonis/chore-samples-rn0.76.0

a75fa9e

Merge branch 'main' into antonis/chore-samples-rn0.76.0

dd7143d

Merge branch 'main' into antonis/chore-samples-rn0.76.0

6a800d3

# Conflicts: # samples/react-native/package.json

Update to 0.76.2

80c975c

Update dependencies

7e4aa97

Update lockfile

622ff2f

Merge branch 'main' into antonis/chore-samples-rn0.76.0

28279bd

antonis changed the title ~~chore(deps): Bumps sample app to RN 0.76.1~~ chore(deps): Bumps sample app to RN 0.76.2 Nov 18, 2024

antonis added 6 commits November 18, 2024 19:21

Polyfill setImmediate if it doesn't exist

88a2854

Require setImmediate

c5c8f76

Revert "Require setImmediate"

8b2e4da

This reverts commit c5c8f76.

require setimmediate if not defined

75e8595

Merge branch 'main' into antonis/chore-samples-rn0.76.0

b5d061e

# Conflicts: # yarn.lock

Align gemfile with RN sample

cc5bb67

antonis marked this pull request as ready for review November 19, 2024 10:51

antonis requested a review from lucas-zimerman as a code owner November 19, 2024 10:51

antonis requested a review from krystofwoldrich November 19, 2024 10:51

antonis added 2 commits November 22, 2024 12:05

Merge branch 'main' into antonis/chore-samples-rn0.76.0

0ee8387

# Conflicts: # samples/react-native/package.json

Bump to 0.76.3

3a6ae09

antonis changed the title ~~chore(deps): Bumps sample app to RN 0.76.2~~ chore(deps): Bumps sample app to RN 0.76.3 Nov 22, 2024

krystofwoldrich reviewed Nov 22, 2024

View reviewed changes

samples/react-native/src/App.tsx Show resolved Hide resolved

krystofwoldrich reviewed Nov 22, 2024

View reviewed changes

Reverts enforcing native module spec

db06022

chore(deps): Bumps sample app to RN 0.76.3 #4207

Are you sure you want to change the base?

chore(deps): Bumps sample app to RN 0.76.3 #4207

Conversation

antonis commented Oct 25, 2024 • edited Loading

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Oct 28, 2024 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/chore-samples-rn0.76.0

Startup times

App size

github-actions bot commented Oct 28, 2024 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/chore-samples-rn0.76.0

Startup times

App size

github-actions bot commented Oct 28, 2024 • edited Loading

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/chore-samples-rn0.76.0

Startup times

App size

github-actions bot commented Oct 28, 2024 • edited Loading

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: antonis/chore-samples-rn0.76.0

Startup times

App size

krystofwoldrich commented Nov 7, 2024

antonis commented Nov 7, 2024

krystofwoldrich Nov 22, 2024

Choose a reason for hiding this comment

antonis Nov 22, 2024

Choose a reason for hiding this comment

krystofwoldrich commented Nov 22, 2024

krystofwoldrich commented Nov 22, 2024

antonis commented Nov 22, 2024

antonis commented Oct 25, 2024 •

edited

Loading

github-actions bot commented Oct 28, 2024 •

edited

Loading

github-actions bot commented Oct 28, 2024 •

edited

Loading

github-actions bot commented Oct 28, 2024 •

edited

Loading

github-actions bot commented Oct 28, 2024 •

edited

Loading