-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spans for streaming responses in WSGI based frameworks #3798
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #3798 +/- ##
==========================================
+ Coverage 79.89% 79.94% +0.05%
==========================================
Files 137 137
Lines 15385 15421 +36
Branches 2611 2614 +3
==========================================
+ Hits 12292 12329 +37
- Misses 2222 2223 +1
+ Partials 871 869 -2
|
…hed." This reverts commit 1fe8679.
…ntry/sentry-python into antonpirker/fix-streaming-response
…ntry/sentry-python into antonpirker/fix-streaming-response
32c40ed
to
c612326
Compare
15eb914
to
30d18fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments. As long as the tests for the various integrations that use the WSGI middleware are happy, I think this looks good.
Fixes spans in streaming responses when using WSGI based frameworks. Only close the transaction once the response was consumed. This way all the spans created during creation of the response will be recorded with the transaction:
People having Sentry in a streaming application will:
Fixes #3736