Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(flags): rename launch darkly hook to match JS SDK #3743

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Nov 5, 2024

No description provided.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.37%. Comparing base (24e5359) to head (d9ead3d).
Report is 14 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3743      +/-   ##
==========================================
- Coverage   84.37%   84.37%   -0.01%     
==========================================
  Files         136      136              
  Lines       14370    14370              
  Branches     2417     2417              
==========================================
- Hits        12125    12124       -1     
  Misses       1495     1495              
- Partials      750      751       +1     
Files with missing lines Coverage Δ
sentry_sdk/integrations/launchdarkly.py 91.17% <100.00%> (ø)

... and 1 file with indirect coverage changes

@antonpirker
Copy link
Member

@cmanallen is this fine with you?

@antonpirker
Copy link
Member

And @aliu39 is this ready for review, because it is a draft?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants