Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scope tests #3593

Draft
wants to merge 3 commits into
base: potel-base
Choose a base branch
from
Draft

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Oct 1, 2024

Fix the Scope related tests in Potel.

Copy link

codecov bot commented Oct 1, 2024

❌ 4467 Tests Failed:

Tests completed Failed Passed Skipped
16467 4467 12000 1591
View the top 3 failed tests by shortest run time
tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_dbapi_breadcrumbs_with_pii
Stack Traces | 0s run time
No failure message available
tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_dbapi_spans_with_pii
Stack Traces | 0s run time
No failure message available
tests.integrations.starlette.test_starlette test_user_information_error
Stack Traces | 0s run time
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@antonpirker antonpirker self-assigned this Oct 1, 2024
@antonpirker antonpirker changed the title Fix client tests Fix Scope tests Oct 1, 2024
@antonpirker antonpirker removed the request for review from sentrivana October 7, 2024 07:53
@antonpirker
Copy link
Member Author

In POTel this only works when there is this with sentry_sdk.start_span() in the test, because this is the point where our scopes are put on the OTel context.

This should also work without having a span. @sl0thentr0py said he will implement a switch to switch to Otel and in that case the Sentry scopes will be put on the OTel context during SDK init().

So I will leave this Issue here until it is time to implement that switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants