Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another approach to fix #1716.
Compared to other SDKs, like Python, the PHP SDK never exposed the transaction name on the scope.
With these changes, the transaction name will be synced with the scope when set on the transaction and vice versa. If an error happens while the transaction is still unfinished, we now set a proper transaction name on the error instead of relying on the user manually passing the name as part of the
EventHint
or relying on theTransactionIntegration
setting$_SERVER['PATH_INFO']
, which is a bad default.Reliably setting the transaction name on all errors allows for some neat features, such as using Discover to create a query to group your transactions by error count.