-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(replay): Remove unused parts of pako from build #9369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we vendor in pako?
It's not so easy because it is all CJS so we'd need to touch every file etc, making updating it etc rather painful 😖 |
size-limit report 📦
|
Nice gains here, can we manually test this to make sure compression still works? |
We have some tests for it (integration tests), where we also decompress events again etc! So I think it should be good, but I can also give it a try with a local test all :) |
See nodeca/pako#268, there is some issue with pako tree shaking ootb.
I've also tried it locally with a test app, compression seems to work fine! 👍 |
See nodeca/pako#268, there is some issue with pako tree shaking ootb.
We don't need all the inflation stuff in our bundle.