test(ember): Update ember tests to use E2E structure #11827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
force-pushed
the
fn/ember-update-tests
branch
from
fb0bc07
to
28e38c5
Compare
mydea
commented
Apr 29, 2024
packages/ember/addon/index.ts
Outdated
| @@ -75,9 +75,11 @@ export const instrumentRoutePerformance = <T extends RouteConstructor>(BaseRoute | |||
| { | |||
| attributes: { | |||
| [SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: source, | |||
| [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.ember', | |||
There was a problem hiding this comment.
this was actually missing, oops.
mydea
commented
Apr 29, 2024
| @@ -145,6 +145,12 @@ export function _instrumentEmberRouter( | |||
|
|
|||
| routerService.on('routeWillChange', (transition: Transition) => { | |||
| const { fromRoute, toRoute } = getTransitionInformation(transition, routerService); | |||
|
|
|||
| // We want to ignore loading && error routes | |||
| if (transitionIsIntermediate(transition)) { | |||
There was a problem hiding this comment.
Ember has a feature where you can easily add loading and error routes that are automatically picked up. However, if you do that it will also trigger transitions for them, which we don't really want here. So we need to filter them out here to avoid that we finish the "actual" routing spans too early.
mydea
force-pushed
the
fn/ember-update-tests
branch
2 times, most recently
from
178c8f9
to
7b22096
Compare
mydea
added a commit
that referenced
this pull request
Apr 30, 2024
Extracted out from #11827. I added tests for loading & error states as well, to ensure this does not regress.
mydea
force-pushed
the
fn/ember-update-tests
branch
3 times, most recently
from
a620ce7
to
a774dd1
Compare
mydea
force-pushed
the
fn/ember-update-tests
branch
from
a774dd1
to
3b83fcc
Compare
mydea
force-pushed
the
fn/ember-update-tests
branch
from
8c7523a
to
91d8eb2
Compare
size-limit report 📦
|
lforst
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of the Ember canary tests that are always failing, probably due to ember-try (which we use there) not playing nicely with the monorepo etc.
Instead, this now uses the proper E2E setup. I added two tests, for classic ember and modern embroider-based ember. While doing this I also noticed two bugs I fixed along the way :O
This also removed the ember canary tests, IMHO the e2e tests are good enough for us there now.