fix: prevent event duplication when JavaBackgroundThread crashes occur
#3756
Conversation
…avaBackgroundThread crashes from creating duplicated event: one UnhandledException one AppDomain.UnhandledException
…d when getting the value to avoid parsing errors
|
Since it's on java crashes, I couldn't find a way to add tests |
| else | ||
| { | ||
| // Prevent JavaBackgroundThread crashes from creating duplicated event: one UnhandledException one AppDomain.UnhandledException | ||
| o.BeforeSend = new BeforeSendCallback(((_, _) => null), options, o); |
There was a problem hiding this comment.
Doesn't this just tell the Android SDK to discard all exceptions? Are there no circumstances in which we want the Android SDK to catch exceptions?
There was a problem hiding this comment.
Are there no circumstances in which we want the Android SDK to catch exceptions?
In this case, they can set an options.Native.EnableBeforeSend to true. But I can't think of any use case in which they would since the event thrown by dotnet has a more detailed set of info
There was a problem hiding this comment.
But what about java exceptions that don't come from a JavaBackgroundThread? This would discard those too right? It's just discarding all and any events that get captured by the Java SDK.
And if the user has set any custom BeforeSend callback, this workaround wouldn't work right???
There was a problem hiding this comment.
But what about java exceptions that don't come from a
JavaBackgroundThread? This would discard those too right? It's just discarding all and any events that get captured by the Java SDK.
All Java exceptions event throws a dotnet event, as far as I can tell.
if the user has set any custom BeforeSend callback, this workaround wouldn't work right???
it would work as long as Native.EnableBeforeSend is not set to true. if it's set to true, it means they technically want the Java event to appear
@bricefriha how did you test it manually? |
I added an attachment at scope configuration and generated a I was trying to make a device test, but that would crash the entire test, since it's an unhandled exception |
Reported on #3545 , this bug yielded two events when
JavaBackgroundThreadcrashes occurred: oneUnhandledExceptionwith no Logcat attachments and no scope attachments and oneAppDomain.UnhandledExceptionwith all expected attachments.This change prevents the
UnhandledExceptionevent to popup.The reason why we are choosing the event with
UnhandledExceptionmechanism overAppDomain.UnhandledExceptionis for consistency purposes, as other Java crashes send a singleAppDomain.UnhandledExceptionevent.