Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve windows config for Cocoa development #3738

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bricefriha
Copy link
Collaborator

In the same veins as PR #3695, since I'm on windows there is a few things I need to adjust when contributing to issues related to cocoa. And since I'm using Visual Studio, these configs are so needed that I have keep them in git stash.

Then, I thought maybe it would be useful to have them on the repo to reduce the friction for new contributors who are on Windows.

Please not

Like for the MAUI sample config changes (#3695), none these configs don't require a mac to be paired.

#skip-changelog

@@ -13,7 +13,7 @@
</PropertyGroup>

<!-- Build empty assemblies when not on macOS, to pass the solution build. -->
<ItemGroup Condition="!$([MSBuild]::IsOSPlatform('OSX'))">
<ItemGroup Condition="!($([MSBuild]::IsOSPlatform('OSX')) Or $([MSBuild]::IsOSPlatform('windows')))">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is going to be problematic in CI. With these files included, it's going to attempt to build the source for Sentry.Bindings.Cocoa on the Windows runner... and that will fail.

Rather than checking for the operating system as a second parameter, perhaps you could check for the existence of an environment variable (EnableRemoteMacBuilds or something) so that anyone developing on Windows with a remote Mac available could turn this on if they want, but it won't mess with the CI builds?

Copy link
Collaborator Author

@bricefriha bricefriha Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea!

but it won't mess with the CI builds?

Let's try not to, but there may be a way not to mess it up

@bricefriha
Copy link
Collaborator Author

@jamescrosswell I'm trying to figure out a way to have this included only if the windows machine is connected to a pair. This way we can even have it run a build of Sentry.Bindings.Cocoa. so essentially, if a mac is paired the machine, it would be the same experience as setting up the environment on a mac. (issue is that the windows instance that the CI run won't be connected to a mac)

it would be technically feasible. the question is would it be worth the effort?
because for sure it would make the project more accessible.

What do you reckon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants