Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (native): update transport proxy docs #11899

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

JoshuaMoelans
Copy link
Member

DESCRIBE YOUR PR

Updated the section on proxy support to match the upcoming socks5 proxy support feature in sentry-native.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:18am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:18am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 8:18am

Copy link

codecov bot commented Nov 21, 2024

Bundle Report

Changes will increase total bundle size by 827 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.28MB 804 bytes (0.01%) ⬆️
sentry-docs-client-array-push 9.29MB 23 bytes (0.0%) ⬆️

Copy link
Collaborator

@supervacuus supervacuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would only highlight technical terms like HTTP, CONNECT, and SOCKS5 with backticks in the prose.

jan-auer and others added 9 commits November 22, 2024 09:03
… images (#11883)

* docs(replay): Document new hydration tree compare, and update related images

* Apply suggestions from code review

Co-authored-by: Alex Krawiec <[email protected]>

---------

Co-authored-by: Alex Krawiec <[email protected]>
Co-authored-by: openapi-getsentry-bot <[email protected]>
* Turn repeated thread locality content into an include

* Update includes/platforms/configuration/options/thread-locality.mdx

Co-authored-by: Liza Mock <[email protected]>

---------

Co-authored-by: Alex Krawiec <[email protected]>
Co-authored-by: James Crosswell <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: openapi-getsentry-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants