Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.mdx to resolve ValueError #10564

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

jvithoulkas
Copy link
Contributor

DESCRIBE YOUR PR

Changed 'endpoint' to 'function_name' within documentation. Found under 'how to name transactions showing in Sentry Tracing'.

Resolves a ValueError when configuring Sentry for Django:
ValueError: Invalid value for transaction_style: endpoint (must be in ('function_name', 'url'))

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Changed 'endpoint' to 'function_name' under how to name transactions showing in Sentry Tracing.

Resolves a ValueError when configuring Sentry for Django:
ValueError: Invalid value for transaction_style: endpoint (must be in ('function_name', 'url'))
Copy link

vercel bot commented Jul 2, 2024

@jvithoulkas is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 8:14pm

@vivianyentran
Copy link
Contributor

@antonpirker Can you help verify this change?

@lizokm
Copy link
Contributor

lizokm commented Jul 8, 2024

@antonpirker Hi there! Gentle nudge to take a quick look at this when you have a moment :)

@antonpirker
Copy link
Member

Hey! Thanks for fixing this! Yes, function_name is the correct value!

@jvithoulkas
Copy link
Contributor Author

Thanks all, happy to help!

@lizokm lizokm merged commit 52e71f0 into getsentry:master Jul 9, 2024
7 checks passed
sentrivana pushed a commit that referenced this pull request Jul 16, 2024
* Update index.mdx

Changed 'endpoint' to 'function_name' under how to name transactions showing in Sentry Tracing.

Resolves a ValueError when configuring Sentry for Django:
ValueError: Invalid value for transaction_style: endpoint (must be in ('function_name', 'url'))

* Update docs/platforms/python/integrations/django/index.mdx

---------

Co-authored-by: Liza Mock <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants