test(debug-files): Add test for assemble endpoint call #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
changed the title
assert_cmd as a dev dependency
szokeasaurusrex
changed the title
loewenheim
approved these changes
Nov 6, 2024
szokeasaurusrex
force-pushed
the
szokeasaurusrex/env-set-function
branch
from
3a0b0e6
to
c46bb3c
Compare
The [`assert_cmd`](https://docs.rs/assert_cmd/latest/assert_cmd/) crate provides an interface which allows more fine-grained control over how an individual integration test is run compared with the `trycmd` crate we currently use everywhere. `assert_cmd` will help us write better integration tests for chunk uploading, which not only assert command output, but also ensure that the correct data is sent to the Sentry server (see #2194).
Add an integration test for the `debug-files upload` command, which ensures that given a certain file, the expected initial request to the assemble endpoint is made to the Sentry server. Unlike existing tests, this test primarily does not serve to validate command output, but rather to ensure other behavior (in this case, that a specific HTTP request is made).
szokeasaurusrex
force-pushed
the
szokeasaurusrex/chunk-upload-test
branch
from
827126e
to
df07728
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/chunk-upload-test
branch
from
2958fe3
to
df07728
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an integration test for the
debug-files uploadcommand, which ensures that given a certain file, the expected initial request to the assemble endpoint is made to the Sentry server. Unlike existing tests, this test primarily does not serve to validate command output, but rather to ensure other behavior (in this case, that a specific HTTP request is made).Also, add the
assert_cmdcrate as a dev dependency. The crate provides an interface which allows more fine-grained control over how an individual integration test is run compared with thetrycmdcrate we currently use everywhere.assert_cmdwill help us write better integration tests for chunk uploading, which not only assert command output, but also ensure that the correct data is sent to the Sentry server (see #2194). We use the crate in this new test.