ref(tests): Decouple test env vars from trycmd code #2218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
force-pushed
the
szokeasaurusrex/env-set-function
branch
from
f11a5b1
to
3a0b0e6
Compare
szokeasaurusrex
changed the base branch from
master
to
szokeasaurusrex/fix-linter
loewenheim
approved these changes
Nov 6, 2024
As a part of #2194, I intend to introduce the [`assert_cmd` crate](https://docs.rs/assert_cmd/latest/assert_cmd/) to have more control over how the assertions for the chunk upload tests are run. This control would be difficult to achieve with `trycmd`. So, here, I am splitting off the logic for setting environment variables to make it also reusable for `assert_cmd` tests
szokeasaurusrex
force-pushed
the
szokeasaurusrex/env-set-function
branch
from
3a0b0e6
to
c46bb3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of #2194, I intend to introduce the
assert_cmdcrate to have more control over how the assertions for the chunk upload tests are run. This control would be difficult to achieve withtrycmd.So, here, I am splitting off the logic for setting environment variables to make it also reusable for
assert_cmdtests