Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spans): Ingest spans #2861

Merged
merged 21 commits into from
Mar 11, 2024
Merged

feat(spans): Ingest spans #2861

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
b31e66f
feat(spans): Ingest spans
phacops Mar 6, 2024
82a8c3a
Enable span extraction from event
phacops Mar 6, 2024
6087506
Add an integration test
phacops Mar 7, 2024
75a2b2b
Remove arithmetic context for simplicity
phacops Mar 7, 2024
246e05b
Add all UI feature flags for spans + Starfish
phacops Mar 7, 2024
61932eb
Rename the consumer group to something specific to spans
phacops Mar 7, 2024
51a8515
Add missing flag
phacops Mar 7, 2024
577f44f
Use single quotes
phacops Mar 11, 2024
5527803
Debug request
phacops Mar 11, 2024
6001f96
Print the body, not the headers
phacops Mar 11, 2024
e54df65
Show the body before we call the failing loop
phacops Mar 11, 2024
ef96b85
Remove bad prefix
phacops Mar 11, 2024
a6c34ec
Fix jq query
phacops Mar 11, 2024
57a3a20
Try to understand what's returned
phacops Mar 11, 2024
9ea5bab
Keep the output but move to the next step
phacops Mar 11, 2024
6381f9e
Let until managed the result
phacops Mar 11, 2024
33a2aa0
Different way for the same thing
phacops Mar 11, 2024
2905b99
Split URL params and encode them if needed
phacops Mar 11, 2024
d036eb9
Different loop
phacops Mar 11, 2024
13c1c1a
Encode properly
phacops Mar 11, 2024
27d5029
More basic approach
phacops Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,9 @@ services:
snuba-profiling-functions-consumer:
<<: *snuba_defaults
command: rust-consumer --storage functions_raw --consumer-group snuba-consumers --auto-offset-reset=latest --max-batch-time-ms 1000 --no-strict-offset-reset --no-skip-write
snuba-spans-consumer:
<<: *snuba_defaults
command: rust-consumer --storage spans --consumer-group snuba-consumers --auto-offset-reset=latest --max-batch-time-ms 1000 --no-strict-offset-reset --no-skip-write
phacops marked this conversation as resolved.
Show resolved Hide resolved
symbolicator:
<<: *restart_policy
image: "$SYMBOLICATOR_IMAGE"
Expand Down
15 changes: 10 additions & 5 deletions sentry/sentry.conf.example.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@

BYTE_MULTIPLIER = 1024
UNITS = ("K", "M", "G")


def unit_text_to_bytes(text):
unit = text[-1].upper()
power = UNITS.index(unit) + 1
return float(text[:-1])*(BYTE_MULTIPLIER**power)
return float(text[:-1]) * (BYTE_MULTIPLIER**power)


# Generously adapted from pynetlinux: https://github.com/rlisagor/pynetlinux/blob/e3f16978855c6649685f0c43d4c3fcf768427ae5/pynetlinux/ifconfig.py#L197-L223
Expand Down Expand Up @@ -114,7 +116,7 @@ def get_internal_network():
"BACKEND": "django.core.cache.backends.memcached.PyMemcacheCache",
"LOCATION": ["memcached:11211"],
"TIMEOUT": 3600,
"OPTIONS": {"ignore_exc": True}
"OPTIONS": {"ignore_exc": True},
}
}

Expand Down Expand Up @@ -191,7 +193,9 @@ def get_internal_network():
###################

SENTRY_RELEASE_HEALTH = "sentry.release_health.metrics.MetricsReleaseHealthBackend"
SENTRY_RELEASE_MONITOR = "sentry.release_health.release_monitor.metrics.MetricReleaseMonitorBackend"
SENTRY_RELEASE_MONITOR = (
"sentry.release_health.release_monitor.metrics.MetricReleaseMonitorBackend"
)

##############
# Web Server #
Expand Down Expand Up @@ -248,7 +252,7 @@ def get_internal_network():
# Mail #
########

SENTRY_OPTIONS["mail.list-namespace"] = env('SENTRY_MAIL_HOST', 'localhost')
SENTRY_OPTIONS["mail.list-namespace"] = env("SENTRY_MAIL_HOST", "localhost")
SENTRY_OPTIONS["mail.from"] = f"sentry@{SENTRY_OPTIONS['mail.list-namespace']}"

############
Expand Down Expand Up @@ -288,6 +292,7 @@ def get_internal_network():
"projects:plugins",
"projects:rate-limits",
"projects:servicehooks",
"projects:span-metrics-extraction",
)
}
)
Expand All @@ -296,7 +301,7 @@ def get_internal_network():
# MaxMind Integration #
#######################

GEOIP_PATH_MMDB = '/geoip/GeoLite2-City.mmdb'
GEOIP_PATH_MMDB = "/geoip/GeoLite2-City.mmdb"

#########################
# Bitbucket Integration #
Expand Down
Loading