-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metrics and generic metrics backend #2355
Conversation
10 new containers on this PR. As far as I experienced this, each Snuba container consumes around 50-100 MB of RAM, and each Sentry ingest container consumes around 60-130 MB of RAM. I'd assume this feature would require at least additional 1 GB of RAM tops (assuming every each of it consumes 100 MB of RAM). Should we bump the minimum specs on the requirements? Lines 5 to 11 in 8c294f5
Edit. Forgot to strike this issue: getsentry/snuba#1670 |
Or should we finally invest in a unified Snuba instance and unified ingest processes? |
Yep, was pretty painful adding another 10 containers here.
Let me see what I can do here in the following weeks. |
That would be cool ! And if you want a supervisor alternative, there is https://github.com/FedericoPonzi/Horust that I got into alpine edge testing ;) |
I don't really think that trimming down the containers to a single container with some kind of supervisor would be different to the consumed resources. As most of us are more likely to have CPU and RAM usage problems instead of storage problems. Python is a language that requires runtime. If you spawn another app (whether it's on a separate container or same container with supervisor), it will be (most likely) the same, because you'd have to have the runtime consuming some minimum CPU and RAM resource to get it running. I'd argue that it'll be better if we have snuba (and sentry ingest) to have unified consumer/ingester instead of having everything supervised. |
Yup, but using Horust, well it's Rust ;)
It's maybe best not to mix everything, but maybe some tasks could be unified in one container per "topic/section" |
Re: unified snuba/ingest instances Will have to scope that out, on the radar for Q4: |
# Metrics Backend # | ||
################### | ||
|
||
SENTRY_RELEASE_HEALTH = "sentry.release_health.metrics.MetricsReleaseHealthBackend" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this live in https://github.com/getsentry/snuba/blob/master/snuba/settings/settings_self_hosted.py instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No this is the right place for the setting. This lets sentry know to load sessions metric data from the metrics
dataset (which is the change you're trying to make).
Snuba will serve up sessions
or metrics
and isn't aware of what the product is doing really
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks right to me, assuming you got it to run locally
# Metrics Backend # | ||
################### | ||
|
||
SENTRY_RELEASE_HEALTH = "sentry.release_health.metrics.MetricsReleaseHealthBackend" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No this is the right place for the setting. This lets sentry know to load sessions metric data from the metrics
dataset (which is the change you're trying to make).
Snuba will serve up sessions
or metrics
and isn't aware of what the product is doing really
@@ -271,6 +278,11 @@ def get_internal_network(): | |||
"organizations:session-replay", | |||
"organizations:issue-platform", | |||
"organizations:profiling", | |||
"organizations:dashboards-mep", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these orgs designed to test the new snuba containers somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those are feature flags that are set at the org level, and utilize the new snuba containers
No description provided.