Fully ensure timeseries for deleted alerts are also purged

getsentry · Nov 21, 2024 · a52053d · a52053d
1 parent e15f312
commit a52053d
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/tests/seer/anomaly_detection/test_cleanup_tasks.py b/tests/seer/anomaly_detection/test_cleanup_tasks.py
@@ -10,7 +10,7 @@
 from seer.anomaly_detection.models.external import AnomalyDetectionConfig, TimeSeriesPoint
 from seer.anomaly_detection.models.timeseries import TimeSeries
 from seer.anomaly_detection.tasks import cleanup_disabled_alerts, cleanup_timeseries
-from seer.db import DbDynamicAlert, Session, TaskStatus
+from seer.db import DbDynamicAlert, DbDynamicAlertTimeSeries, Session, TaskStatus
 
 
 class TestCleanupTasks(unittest.TestCase):
@@ -196,6 +196,13 @@ def test_cleanup_disabled_alerts(self):
                 )
                 assert alert is None
 
+                timeseries = (
+                    session.query(DbDynamicAlertTimeSeries)
+                    .filter(DbDynamicAlertTimeSeries.dynamic_alert_id == alert_id)
+                    .all()
+                )
+                assert len(timeseries) == 0
+
         # Confirm that alert 4 and its respective timeseries are not deleted
         with Session() as session:
             alert = (