feat(spooler): Add file backed envelope stacks #4138
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
reviewed
Oct 18, 2024
relay-config/src/config.rs
Outdated
Comment on lines
1021
to
1022
| #[default] | ||
| Memory, |
There was a problem hiding this comment.
With this default, our currently deployed configs will revert to Memory even if they have a path set.
Bonus points if you can make it an adjacently or untagged enum while maintaining backward compatibility:
Memory,
Sqlite(PathBuf),
FileBacked(PathBuf)There was a problem hiding this comment.
Yes, this is a good point. I will try to make it work.
This was referenced Oct 23, 2024
jjbayer
added a commit
that referenced
this pull request
Oct 28, 2024
Adds the benchmarking tool introduced in #4138. Example usage: ```shell ./target/release/bench-buffer \ --envelope-size-kib 100 \ --batch-size 1 \ --implementation sqlite \ --mode sequential \ --projects 100000 \ --duration-secs 100 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new file backend envelope stack, creating a file per
own_keyproject_keycombination. The files have a custom format designed for fast access and the data layout is explained in code comments.The whole idea of this mechanism is that we always append and remove data from the end of the file, meaning no in-memory buffering takes place. When a file is found to be empty, it will be removed from the file system.
In the future, given our file-per-pair model, we could parallelize spools and batch them.