fix(replays): Lower segment_id cap to one hour

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## Unreleased
+
+**Internal**:
+
+- Decrease max allowed segment_id for replays. ([#3280]https://github.com/getsentry/relay/pull/3280)
+
 ## 24.6.0
 
 **Bug fixes**:

py/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## Unreleased
+
+**Internal**:
+
+- Decrease max allowed segment_id for replays. ([#3280]https://github.com/getsentry/relay/pull/3280)
+
 ## 0.8.67
 
 ### Various fixes & improvements

relay-event-normalization/src/replay.rs

@@ -51,9 +51,9 @@ pub fn validate(replay: &Replay) -> Result<(), ReplayError> {
         .value()
         .ok_or_else(|| ReplayError::InvalidPayload("missing segment_id".to_string()))?;
 
-    if segment_id > u16::MAX as u64 {
+    if segment_id > 720 {
         return Err(ReplayError::InvalidPayload(
-            "segment_id exceeded u16 limit".to_string(),
+            "segment_id limit exceeded".to_string(),
         ));
     }
 
@@ -365,22 +365,20 @@ mod tests {
     }
 
     #[test]
-    fn test_validate_u16_segment_id() {
-        // Does not fit within a u16.
+    fn test_validate_segment_id() {
         let replay_id =
             Annotated::new(EventId("52df9022835246eeb317dbd739ccd059".parse().unwrap()));
-        let segment_id: Annotated<u64> = Annotated::new(u16::MAX as u64 + 1);
+        let segment_id: Annotated<u64> = Annotated::new(721);
         let mut replay = Annotated::new(Replay {
             replay_id,
             segment_id,
             ..Default::default()
         });
         assert!(validate(replay.value_mut().as_mut().unwrap()).is_err());
 
-        // Fits within a u16.
         let replay_id =
             Annotated::new(EventId("52df9022835246eeb317dbd739ccd059".parse().unwrap()));
-        let segment_id: Annotated<u64> = Annotated::new(u16::MAX as u64);
+        let segment_id: Annotated<u64> = Annotated::new(720);
         let mut replay = Annotated::new(Replay {
             replay_id,
             segment_id,