feat(dependency): Adding dependency graph to start services #163
+560
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
+ Coverage 90.67% 90.98% +0.31%
==========================================
Files 20 20
Lines 1104 1154 +50
==========================================
+ Hits 1001 1050 +49
- Misses 103 104 +1 ☔ View full report in Codecov by Sentry. |
IanWoodard
commented
Nov 22, 2024
Comment on lines
+1892
to
+1894
| "grandparent-service": { | ||
| "description": "grandparent-service", | ||
| }, |
There was a problem hiding this comment.
I see why we have this, but aren't we planning on moving away from this pattern and toward having different naming for self-referenced containerized versions of the service?
hubertdeng123
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our logic does not handle bringing up services in the correct order such that dependencies are started before their dependents. This change addresses that by constructing a dependency graph and using reverse topological ordering to determine the ordering in which we should bring services up.