metric(multiprocessing): Add metric to track time it takes to prepare and submit batch #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhars
approved these changes
Apr 10, 2024
nikhars
reviewed
Apr 10, 2024
| if self.__last_batch_time == 0.0: | ||
| self.__last_batch_time = time.time() | ||
| else: | ||
| self.__metrics.timing("arroyo.strategies.run_task_with_multiprocessing.batch.build_and_submit_time", time.time() - self.__last_batch_time) |
There was a problem hiding this comment.
I think you also need to reset self.__last_batch_time to 0 here.
There was a problem hiding this comment.
Oops forgot that line. I think we need to reset it to the current time (so that we have the time that the previous batch was submitted)
|
Need to fix the tests since the |
lynnagara
reviewed
Apr 11, 2024
arroyo/utils/metric_defs.py
Outdated
| @@ -98,4 +98,6 @@ | |||
| "arroyo.processing.strategies.healthcheck.touch", | |||
| # Number of messages dropped in the FilterStep strategy | |||
| "arroyo.strategies.filter.dropped_messages", | |||
| # The amount of time it takes for the multiprocessing batch to be built and submitted to subprocesses | |||
| "arroyo.strategies.run_task_with_multiprocessing.batch.build_and_submit_time" | |||
There was a problem hiding this comment.
Suggested change
| "arroyo.strategies.run_task_with_multiprocessing.batch.build_and_submit_time" | |
| "arroyo.strategies.run_task_with_multiprocessing.batch_build_and_submit_time" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.