Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timeout-option/parameter to start_discovery(...) #45

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JlnWntr
Copy link

@JlnWntr JlnWntr commented Mar 26, 2019

I had to re-open this pull-request, because I deleted my first fork of gatt-python. I'm sorry for that.

But I've now implemented blumberg's suggestion.

@mdxs
Copy link

mdxs commented Feb 21, 2020

Would it be an idea to have the default of 10 sec (10000 ms) in the function when the timeout parameter is missing? So that when it is not explicitly provided, that 10 sec is used; then the explicit option added in the "using" call could be omitted. If acceptable, perhaps an explicit 0 would have it not timeout, meaning that when timeout=0 is provided as parameter input, the discovery keeps on running (which is what I understand happened before this PR).

@jlusiardi
Copy link
Contributor

I agree with @mdxs and go for a default timeout of 10s. It should also be documented what a value of None means for the timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants