Skip to content

Commit

Permalink
scenario: update test now passing with escaped XForm DSL attribute va…
Browse files Browse the repository at this point in the history
…lues
  • Loading branch information
eyelidlessness committed Jul 15, 2024
1 parent 53c0a91 commit 721c82c
Showing 1 changed file with 2 additions and 12 deletions.
14 changes: 2 additions & 12 deletions packages/scenario/test/secondary-instances.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -274,19 +274,9 @@ describe('Secondary instances', () => {
/**
* **PORTING NOTES**
*
* 1. Rephrase?
* 2. Failure is caused by `<` in the first `calculate` predicate. The
* current DSL logic (which has been rechecked for consistency with
* JavaRosa) appears to produce invalid XML in this case (and in
* general does not do a lot of sanitization for attributes; I've seen
* similar errors when authoring new fixtures with the DSL).
* 3. Test passes otherwise (with `<` escaped as `&lt;` in situ).
* 4. This is one example where JSX might be a good option for future
* iteration on the DSL itself (as attributes/props are first class in
* the JSX grammar, and escaping would be handled consistently without
* special serialization logic).
* Rephrase?
*/
it.fails('[does] do not get confused', async () => {
it('[does] do not get confused', async () => {
const scenario = await Scenario.init(
'Some form',
html(
Expand Down

0 comments on commit 721c82c

Please sign in to comment.