Enable host setup loading via ENV variable #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like Implementation looks good as well. 👍 |
distantnative
approved these changes
May 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now load a different host config by setting the new KIRBY_HOST env variable:
@lukasbestle could you have a look at this. I tried to also implement the idea of an additional --env or --host option, but we need to load Kirby first before we can really start parsing the arguments and it would have turned into a bad hack.
I found HOST to be better than ENV, but I wonder if we should do KIRBY_CLI_HOST instead? Not entirely sure.