Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New clear:lock command #59

Merged
merged 2 commits into from
Feb 22, 2024
Merged

New clear:lock command #59

merged 2 commits into from
Feb 22, 2024

Conversation

afbora
Copy link
Member

@afbora afbora commented Feb 22, 2024

No description provided.

@afbora afbora added the type: feature 🎉 Adds a feature (requests → feedback.getkirby.com) label Feb 22, 2024
@afbora afbora requested a review from a team February 22, 2024 12:31
@afbora afbora self-assigned this Feb 22, 2024
@afbora afbora added this to the 1.4.0 milestone Feb 22, 2024
bastianallgeier
bastianallgeier approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a simple counter. The rest is awesome.

@bastianallgeier bastianallgeier changed the base branch from main to develop February 22, 2024 12:54
@bastianallgeier bastianallgeier changed the base branch from develop to main February 22, 2024 12:54
@bastianallgeier bastianallgeier changed the base branch from main to develop February 22, 2024 12:55
@bastianallgeier bastianallgeier merged commit 1a37e3d into develop Feb 22, 2024
10 checks passed
@bastianallgeier bastianallgeier deleted the feature/clear-locks branch February 22, 2024 12:55
@afbora
Copy link
Member Author

afbora commented Feb 22, 2024

Thank you 👍

  • I thought of a counter but didn't implement it.
  • I preferred main branch instead of develop because develop branch was behind of main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@afbora afbora

Labels
type: feature 🎉 Adds a feature (requests → feedback.getkirby.com)
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@afbora @bastianallgeier