Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the "As mentioned earlier" part in ch1.md #1789

Open
wants to merge 1 commit into
base: 2nd-ed
Choose a base branch
from

Conversation

SiarheiBobryk
Copy link

Maybe I'm wrong (hope I'm not), I don't remember any mentions about an array type at that point of the book. I've tried to find it, but I found nothing. It might be an artefact of the original book (the 1st edition).

So I'd replace the "As mentioned earlier" part with something not confusing. I'm not a native English, so probably you have a better idea for the replacement.

"I already searched for this issue"

Edition: 2nd

Book Title: You Don't Know JS Yet: Get Started

Chapter: 2

Section Title: Values

Topic: Arrays And Objects

Maybe I'm wrong (hope I'm not), I don't remember any mentions about an
array type at that point of the book. I've tried to find it, but I found
nothing. It might be an artefact of the original book (the 1st edition).

So I'd replace the "As mentioned earlier" part with something not
confusing. I'm not a native English, so probably you have a better idea
for the replacement.
@@ -123,7 +123,7 @@ You won't encounter direct usage of symbols very often in typical JS programs. T

Besides primitives, the other value type in JS is an object value.

As mentioned earlier, arrays are a special type of object that's comprised of an ordered and numerically indexed list of data:
It is worth mentioning that JS arrays are a special type of object that's comprised of an ordered and numerically indexed list of data:
Copy link

@Lasitha92 Lasitha92 Jun 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be like this right?
special type of objects that comprised of an ordered and numerically ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants