[WIP] Upgrade to Ruby 3.0 #204
Draft
+163
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't use it, and having it enabled makes upgrading Rails harder.
`update_attributes` will be removed in Rails 6.1. This deprecation
warning was being printed:
update_attributes is deprecated and will be removed from Rails 6.1
(please, use update instead)
This prevents the following deprecation warning:
DEPRECATION WARNING: SourceAnnotationExtractor is deprecated! Use
Rails::SourceAnnotationExtractor instead. (called from <top
(required)> at
/Users/pat/projects/guesstimate-server/config/application.rb:12)
This isn't for any reason in particular. We're on and old version and it's a safe upgrade.
The master branch of actionpack-action_caching has Rails 6.1 support,
but a new version of the gem hasn't been released yet, so we need to
source it from GitHub.
Without the addition of `require "active_support/core_ext/integer/time"`
to `application.rb`, we get this error:
An error occurred while loading ./spec/models/user_spec.rb.
Failure/Error: require File.expand_path('../../config/environment', __FILE__)
NoMethodError:
undefined method `day' for 1:Integer
This sort of deprecation warning was being printed:
DEPRECATION WARNING: Calling `<<` to an ActiveModel::Errors message
array in order to add an error is deprecated. Please call
`ActiveModel::Errors#add` instead. (called from fact_has_stats at
/Users/pat/projects/guesstimate-server/app/models/fact.rb:70)
This prevents the following deprecation warning:
Sending mail with DeliveryJob and Parameterized::DeliveryJob is
deprecated and will be removed in Rails 6.2. Please use
MailDeliveryJob instead.
patbl
force-pushed
the
upgrade-to-rails-6.1
branch
from
7a15043
to
2881105
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to see if this is an easy upgrade. It's not.
One big problem is that Roar and Roar Rails (https://github.com/apotonick/roar-rails) aren't maintained, but they're used extensively in the app. Migrating to something else might be formulaic and straightforward, but it would likely require a lot of testing because it would require changing code in a lot of places. An alternative would be to fork Roar and make it compatible with Ruby 3.0. I checked the existing forks (https://github.com/trailblazer/roar/network/members), but none of them had commits more recent than the latest commit in the upstream repo (August 14, 2019).
Anyway, Ruby 2.7 is only a year and a few months old, and will probably be supported for another couple of years. So this upgrade isn't urgent.