Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed field.classes on some field types. #2432

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

pmoreno-rodriguez
Copy link
Contributor

No description provided.

@pmoreno-rodriguez pmoreno-rodriguez changed the title Added field.classes for some missing field types Changed field.classes on some field types. New div block for field.outerclasses. New headgin_classes tag for h1 tag Dec 23, 2024
@pmoreno-rodriguez pmoreno-rodriguez changed the title Changed field.classes on some field types. New div block for field.outerclasses. New headgin_classes tag for h1 tag Changed field.classes on some field types. Dec 23, 2024
pmoreno-rodriguez added a commit to pmoreno-rodriguez/grav-plugin-admin that referenced this pull request Dec 23, 2024
@rhukster
Copy link
Member

Just fyi the biggest issue is consistency between the structure of this fields in the form plugin and the admin plugin. Admin uses both fields from its own location as well as those from the form’s, while front end only has access to form’s fields.

@pmoreno-rodriguez
Copy link
Contributor Author

So, I understand that I should find a way to standardize both the fields of the form plugin and the admin plugin, so that both use the same class attributes in the same types of fields, while including those common attributes in the Grav documentation. Am I right? If so, I will spend time searching in all the templates of both the Form and Admin plugin to try to standardize the common attributes in both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants