-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module/form manager #2098
Open
nurul-umbhiya
wants to merge
126
commits into
develop
Choose a base branch
from
module/form_manager
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,764
−2,772
Open
Module/form manager #2098
Changes from 113 commits
Commits
Show all changes
126 commits
Select commit
Hold shift + click to select a range
f0d6e79
feat: Product form custom validation. Added support to settings secti…
devAsadNur 2dbcde1
enhance: Added reset all button to the admin settings component
devAsadNur bedbe32
fix: Action button was not working
devAsadNur 440dac1
Merge branch 'develop' into feat/product-form-custom-validation
devAsadNur a55be72
enhance: Added admin settings sub-section column heading support
devAsadNur bc789b4
enahnce: Added support for disabling field for Switches component
devAsadNur 18057d7
fix: Styling for the settings sub heading column styles
devAsadNur c391f7b
Updated admin setting reset all link with button
devAsadNur 2f430c9
Added admin settings sub-section toggle button label
devAsadNur 3eb324c
Merge branch 'feat/product-form-custom-validation' into module/form_m…
devAsadNur 9ada0e4
Removed extra sub-sections and moved form manager block to a separete…
devAsadNur 7b36504
Cleaned up some unused codes
devAsadNur 50402b0
refactor: Form manager settings section moved to Dokan Pro
devAsadNur d17cb3d
fix: Console error on field toggle switching
devAsadNur d8edffa
Added product types to the admin localized script
devAsadNur 6f0e7f7
Added support for settings section repeater
devAsadNur 9d90ea6
new: added skeleton for product fields feature
nurul-umbhiya 63d0b60
Merge remote-tracking branch 'origin/develop' into refactor/dashboard…
nurul-umbhiya af756c6
refactor: removed `Add New Product` page and modal related codebase a…
nurul-umbhiya a634761
refactor: replace action hook: dokan_product_updated with filter hook…
nurul-umbhiya b869ff8
fix: fixed some minor issues
nurul-umbhiya 2e410e6
Merge remote-tracking branch 'origin/develop' into refactor/dashboard…
nurul-umbhiya fc5ff41
🔒 chore(Product): add defined( 'ABSPATH' ) || exit; to Hooks.php and …
nurul-umbhiya 62aa976
Merge remote-tracking branch 'origin/develop' into module/form_manager
nurul-umbhiya 70553c5
Merge remote-tracking branch 'origin/refactor/dashboard_products' int…
nurul-umbhiya bb27153
update: Made general product section mandatory for product form custo…
devAsadNur 7f2f9fb
Localized product fields data and get those from the product editor s…
devAsadNur dc0d791
enhance: Added asterisk symbol markup for required fields
devAsadNur 870738d
Added missing required asterisk symbol on various fields and removed …
devAsadNur 7475c22
update: Included argument to the 'dokan_product_form_item_created' f…
devAsadNur 7961933
Made the input fields required from HTML end based on admin settings
devAsadNur f1890fa
Added support for the custom product form fields
devAsadNur ecdf1c4
fix: Updated input value for product title not remaining if product f…
devAsadNur 00fe573
Added JS support for the image and other media file upload and select
devAsadNur aee9ca2
Enhance: Added support for date range picker for custom product fields
devAsadNur 04239aa
Fixed date range picker desappearing issue and added support for both…
devAsadNur 19731cb
refactor: Moved scripts related to product custom fields from Dokan L…
devAsadNur 400cc06
new: Added some hooks in vendor dashboard product form templates
devAsadNur b41f4ea
enhance: Added custom fields support to the predefined product form s…
devAsadNur 0746cd1
enahnce: Added mechanism for preserveform submission data for general…
devAsadNur 0254f10
enhance: Added mechanism for inventory section form data upon product…
devAsadNur 08090af
fix: Wrong value showing on date from, date to, and image thumbnil field
devAsadNur 39ffc81
enhance: Added mechanism for Other Options section form data upon pr…
devAsadNur 8945cb8
enhance: Added mechanism to keep downloadable section form data upon …
devAsadNur 2598b21
Fixed styling issue of vendor dashboard product form shipping section…
devAsadNur a8491c0
chore: merged develop branch
devAsadNur 889449d
fix: Missing help text for the Others section fields on vendor dashbo…
devAsadNur c27a0eb
Merge remote-tracking branch 'upstream/develop' into module/form_manager
devAsadNur afa7080
enhance: Added support for conditional dependent blocks and fields
devAsadNur e13028e
enhance: Made fields under inventory section conditinally dependent
devAsadNur acb81d2
fix: Broken style for the custom fields under downloadable section on…
devAsadNur 581a09c
fix: Missing 'Downloadable Options' section on vendor dashboard singl…
devAsadNur 69b8a12
fix: Disappeared price and dolownlad related input fields from vendor…
devAsadNur 645a7ba
enhance: Added support to render product form sections based on produ…
devAsadNur 1e399eb
enhance: Category based custom section support for vendor dashboard p…
devAsadNur 0198461
fix: Rendering category selector multiple times on vendor dashboard p…
devAsadNur 633b521
enhance: Added searching support to the multi-step categories API
devAsadNur a743cd1
fix: Caching issue for the multi-step categories seaching through API
devAsadNur 929f5bc
refactor: Reverted searching mechanism from the multi-step categories…
devAsadNur 70e2ea0
fix: Wrongly placed asterisk sign for requried general product fields…
devAsadNur 58cbdba
fix: Missing help texts and some styling issues on vendor dashboard g…
devAsadNur 239f504
fix: Tooltip issues on vendor dashboard product form fields
devAsadNur fa3fb9b
Merge branch 'develop' into module/form_manager
nurul-umbhiya 8b66e38
Merge branch 'develop' into module/form_manager
devAsadNur 1376cc7
enhance: Integrated frontend form validation to the vendor dashboard …
devAsadNur c4cbc84
fix: Switches on admin settings were can't be enabled after merging w…
devAsadNur c96ee57
fix: Error message on vendor dashboard product form frontend validation
devAsadNur dd45805
Remove product create popup javascript code.
Aunshon 8d666bd
Merge branch 'develop' into module/form_manager
devAsadNur d4563c6
enhance: Handled backend validation for discount schedule date from a…
devAsadNur c72fef6
Handled downloadable options section fields backend validation based …
devAsadNur f1f48a9
Handled virtual and shipping related fields backend validation
devAsadNur ee58880
fix: Discounted price date schedule fields validation issue
devAsadNur d45b8e7
enhance: Integrated backend conditional validation for stock manager …
devAsadNur f7ce607
Merge remote-tracking branch 'upstream/module/form_manager' into modu…
devAsadNur bf36c8d
fix: Product form customizer settings reset button not reseting field…
devAsadNur a434e13
chore: variation product rewrite
nurul-umbhiya 88cc82b
chore: rewritten product variation related php codes
nurul-umbhiya 229139f
Merge remote-tracking branch 'origin/develop' into module/form_manager
nurul-umbhiya 9e08b18
chore: added assets/js/dokan-tailwind.js file to gitignore
nurul-umbhiya 5750393
Merge remote-tracking branch 'origin/develop' into module/form_manager
nurul-umbhiya daaaa26
chore: fixed some phpcs related issues
nurul-umbhiya 2c42450
update: added a new property for component class to conditionally hid…
nurul-umbhiya ec88e80
fix: product type id doesn't match with existing source code, hence P…
nurul-umbhiya 531bc8b
chore: moved attribute related js code to dokan pro
nurul-umbhiya 985684f
fix: textarea populating multiple white spaces
nurul-umbhiya 0c7d55f
Merge remote-tracking branch 'origin/develop' into module/form_manager
nurul-umbhiya 64e16f2
fix: product status not updating according to the admin settings
nurul-umbhiya 599d413
fix: simple subscription product type data not saving to database
nurul-umbhiya 34029c7
core: added a new filter to escape required fields validation
nurul-umbhiya 8082724
chore: removed one step product form notice from admin panel
nurul-umbhiya e6ea576
fix: Reset all button was not workingon product form admin settings
devAsadNur cb51e17
Merge branch 'develop' into module/form_manager
devAsadNur aaee6a1
fix: Modified based on PR review request
devAsadNur 8ee16c2
Merge branch 'develop' into module/form_manager
devAsadNur 693c6de
fix: Fatal error error on activating product form module
devAsadNur 374c796
Merge branch 'develop' into module/form_manager
shashwatahalder01 3c175da
Update tests for form manager
shashwatahalder01 654614a
Fix a test
shashwatahalder01 59aa377
fix: Default category not auto selecting on creating new product
devAsadNur 659e645
Merge remote-tracking branch 'upstream/module/form_manager' into modu…
devAsadNur 02adcbf
Merge branch 'develop' into module/form_manager
devAsadNur 6043469
fix: Return type was incorrect for product manager delete method
devAsadNur 935f03e
Merge branch 'develop' into module/form_manager
devAsadNur 7c0c718
Fix failed test locator
shashwatahalder01 40b08c6
Merge remote-tracking branch 'upstream/module/form_manager' into modu…
devAsadNur 49825ee
fix: Layout breaking issue of vendor dashboard product shipping input
devAsadNur e2ef682
update: Product SKU field title in vendor dashboard single product ed…
devAsadNur 4b33118
fix: Product edit page shipping dimension input fields styling issues…
devAsadNur dd6f3db
refactor: Reverted product variation related dokan pro i18n strings t…
devAsadNur 0e05b17
fix: Product type dropdown was missing on vendor dashboard product ed…
devAsadNur 78eaa59
fix: Vendor dashboard product edit page data saving issues of Dokan P…
devAsadNur fabbc1a
fix: Undefined variable warning on vendor dashboard product category …
devAsadNur ec05bc8
refactor: dokan_product_form_fields filter hook moved to product fact…
devAsadNur cd745e8
Merge branch 'develop' into module/form_manager
devAsadNur 36f4fc2
refactor: Registered ProductForm service provider to container common…
devAsadNur faae548
new: Introduced DOKAN_TEMPLATE_DIR constant
devAsadNur 38556db
Merge branch 'develop' into module/form_manager
devAsadNur 1c91942
refactor: Action hooks to the edit-product-single template after reso…
devAsadNur b92694d
fix: Removed extra ending sign of PHP form product edit title
devAsadNur cd4c744
refactor: Featured image preview on vendor dashbaord product edit page
devAsadNur 2af1fbb
Merge branch 'develop' into module/form_manager
devAsadNur b13cd3b
refactor: Price and category fiels on vendor dashbaord product edit p…
devAsadNur a04c74b
Merge remote-tracking branch 'origin/develop' into module/form_manager
devAsadNur 0ecb790
fix: Gallery image restriction was not working
devAsadNur 1c36c1c
refactor: Product meta processor method for gallery image restriction
devAsadNur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Padding change appears inconsistent with responsive design patterns
The codebase shows multiple declarations of
.instruction-inside
with different padding approaches:The change from percentage-based padding to fixed pixels could cause layout issues across different viewport sizes, especially since the file already contains mobile-specific media queries (@media max-width: 430px).
Recommend:
🔗 Analysis chain
Verify the increased padding impact on layout.
The padding-top has been significantly increased from 20px to 80px. While this might improve visual spacing, please verify that it doesn't cause any layout issues or excessive whitespace in different viewport sizes.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 262
Script:
Length of output: 4309