-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module/form manager #2098
base: develop
Are you sure you want to change the base?
Module/form manager #2098
Changes from 117 commits
f0d6e79
2dbcde1
bedbe32
440dac1
a55be72
bc789b4
18057d7
c391f7b
2f430c9
3eb324c
9ada0e4
7b36504
50402b0
d17cb3d
d8edffa
6f0e7f7
9d90ea6
63d0b60
af756c6
a634761
b869ff8
2e410e6
fc5ff41
62aa976
70553c5
bb27153
7f2f9fb
dc0d791
870738d
7475c22
7961933
f1890fa
ecdf1c4
00fe573
aee9ca2
04239aa
19731cb
400cc06
b41f4ea
0746cd1
0254f10
08090af
39ffc81
8945cb8
2598b21
a8491c0
889449d
c27a0eb
afa7080
e13028e
acb81d2
581a09c
69b8a12
645a7ba
1e399eb
0198461
633b521
a743cd1
929f5bc
70e2ea0
58cbdba
239f504
fa3fb9b
8b66e38
1376cc7
c4cbc84
c96ee57
dd45805
8d666bd
d4563c6
c72fef6
f1f48a9
ee58880
d45b8e7
f7ce607
bf36c8d
a434e13
88cc82b
229139f
9e08b18
5750393
daaaa26
2c42450
ec88e80
531bc8b
985684f
0c7d55f
64e16f2
599d413
34029c7
8082724
e6ea576
cb51e17
aaee6a1
8ee16c2
693c6de
374c796
3c175da
654614a
59aa377
659e645
02adcbf
6043469
935f03e
7c0c718
40b08c6
49825ee
e2ef682
4b33118
dd6f3db
0e05b17
78eaa59
fabbc1a
ec05bc8
cd745e8
36f4fc2
faae548
38556db
1c91942
b92694d
cd4c744
2af1fbb
b13cd3b
a04c74b
0ecb790
1c36c1c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,7 @@ | |
* @property WeDevs\Dokan\BackgroundProcess\Manager $bg_process Instance of WeDevs\Dokan\BackgroundProcess\Manager class | ||
* @property WeDevs\Dokan\Withdraw\Manager $withdraw Instance of WeDevs\Dokan\Withdraw\Manager class | ||
* @property WeDevs\Dokan\Frontend\Frontend $frontend_manager Instance of \WeDevs\Dokan\Frontend\Frontend class | ||
* @property WeDevs\Dokan\Dashboard\Manager $dashboard Instance of \WeDevs\Dokan\Dashboard\Manager class | ||
* @property WeDevs\Dokan\Registration $registration Instance of WeDevs\Dokan\Registration class | ||
*/ | ||
final class WeDevs_Dokan { | ||
|
@@ -214,6 +215,7 @@ public function define_constants() { | |
defined( 'DOKAN_PLUGIN_VERSION' ) || define( 'DOKAN_PLUGIN_VERSION', $this->version ); | ||
defined( 'DOKAN_DIR' ) || define( 'DOKAN_DIR', __DIR__ ); | ||
defined( 'DOKAN_INC_DIR' ) || define( 'DOKAN_INC_DIR', __DIR__ . '/includes' ); | ||
defined( 'DOKAN_TEMPLATE_DIR' ) || define( 'DOKAN_TEMPLATE_DIR', __DIR__ . '/templates' ); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Template directory constant needs to be used consistently The verification reveals inconsistent template path handling across the codebase:
For consistency and maintainability:
🔗 Analysis chainVerify template directory constant usage The constant definition looks good, but let's ensure it's being used consistently across the codebase. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for existing usages of hardcoded template paths that should use DOKAN_TEMPLATE_DIR
# Search for hardcoded template paths
rg -g '*.php' "(?i)(templates?.*directory|template.*path|template.*dir)"
# Search for current usage of the new constant
rg "DOKAN_TEMPLATE_DIR"
Length of output: 6453 |
||
defined( 'DOKAN_LIB_DIR' ) || define( 'DOKAN_LIB_DIR', __DIR__ . '/lib' ); | ||
defined( 'DOKAN_PLUGIN_ASSEST' ) || define( 'DOKAN_PLUGIN_ASSEST', plugins_url( 'assets', DOKAN_FILE ) ); | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Padding change appears inconsistent with responsive design patterns
The codebase shows multiple declarations of
.instruction-inside
with different padding approaches:The change from percentage-based padding to fixed pixels could cause layout issues across different viewport sizes, especially since the file already contains mobile-specific media queries (@media max-width: 430px).
Recommend:
🔗 Analysis chain
Verify the increased padding impact on layout.
The padding-top has been significantly increased from 20px to 80px. While this might improve visual spacing, please verify that it doesn't cause any layout issues or excessive whitespace in different viewport sizes.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 262
Script:
Length of output: 4309