Add new fields to DockerRuleParams #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 28, 2016 15:49
ContainerConfig config - creating custom setting for container; String dockerHost, String dockerCertPath - for setting this params from code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was writing local tests with the use of your dockerRule and docker toolbox I faced with the following problems:
I needed to set DOCKER_HOST and DOCKER_CERT_PATH in env settings, therefore I added DockerRuleBuilder, dockerHost and dockerCertPath.
Also when I created docker container I needed to set env property for it. That’s why I added ContainerConfig to the DockerRuleBuilder so that it would be possible to pass any settings to container.
Following that I want to add some code to your project so that such problems were resolved