Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait before proceed parameter #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

coders-kitchen
Copy link

I realized today that some containers need a separate wait step before the checks for port or log line could be executed.

For example the official postgres container restarts postgres once, to enable some settings.

This change introduces the parameter waitBeforeProceed which, if set, waits the specified time before the other checks are executed.

@geowarin
Copy link
Owner

geowarin commented Nov 13, 2017

Hey @coders-kitchen.
Thanks for your PR !

Looking at test-containers, they have a better dsl that they use to wait for events:

https://github.com/testcontainers/testcontainers-java/blob/56513a44e21d21dc15d14416806775b80c252efd/modules/postgresql/src/main/java/org/testcontainers/containers/PostgreSQLContainer.java#L26-L29

I think I'll try to implement something like this, what do you think ?
It seems better than waiting for an empirical duration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants