Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pgwar project statements #360

Merged
merged 15 commits into from
Jun 12, 2024
Merged

Pgwar project statements #360

merged 15 commits into from
Jun 12, 2024

Conversation

dferhod
Copy link
Contributor

@dferhod dferhod commented Jun 11, 2024

No description provided.

@dferhod dferhod requested a review from joschne June 11, 2024 15:20
@joschne joschne changed the base branch from main to pgwar-statements June 11, 2024 18:17
Copy link
Collaborator

@joschne joschne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetic changes requested and extension of the integration test requested.

project_statements.ord_num_of_range IS DISTINCT FROM EXCLUDED.ord_num_of_range OR
project_statements.object_label IS DISTINCT FROM EXCLUDED.object_label OR
project_statements.object_value IS DISTINCT FROM EXCLUDED.object_value;
RAISE NOTICE 'Project statement %s', ps;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Notice

@joschne joschne merged commit 3cbf3b4 into pgwar-statements Jun 12, 2024
1 check passed
@joschne joschne deleted the pgwar-project-statements branch June 12, 2024 10:42
@joschne joschne restored the pgwar-project-statements branch June 12, 2024 10:47
@joschne joschne deleted the pgwar-project-statements branch June 12, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants