-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pgwar project statements #360
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement pwar-entity
Pgwar-statements
Pgwar entity
…linux distro like Ubuntu
joschne
requested changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cosmetic changes requested and extension of the integration test requested.
database/migrations/sqls/20240606082339-pgwar-project-statements-up.sql
Outdated
Show resolved
Hide resolved
project_statements.ord_num_of_range IS DISTINCT FROM EXCLUDED.ord_num_of_range OR | ||
project_statements.object_label IS DISTINCT FROM EXCLUDED.object_label OR | ||
project_statements.object_value IS DISTINCT FROM EXCLUDED.object_value; | ||
RAISE NOTICE 'Project statement %s', ps; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove Notice
database/migrations/sqls/20240606082339-pgwar-project-statements-up.sql
Outdated
Show resolved
Hide resolved
database/test/integration/pgwar-project-statements/test-pgwar-project-statements.sql
Outdated
Show resolved
Hide resolved
joschne
reviewed
Jun 12, 2024
database/test/integration/pgwar-project-statements/test-pgwar-project-statements.sql
Show resolved
Hide resolved
… made no change to them.
…gwar-project-statements
joschne
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.