Added write support for Artist, Make, Model, ImageDescription & Copyright ASCII Baseline TIFF tags #431
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mapping the Baseline ASCII TIFF Tags to an ASCII data type to allow for writing of them. geotiffjs#430
|
Awesome work! Looks good to me! |
DanielJDufour
approved these changes
Jun 20, 2024
|
Thanks @timhj, looks solid. |
|
@DanielJDufour @constantinius - Nice to see this progressing, thanks for checking it. Any idea when the next release will happen that includes this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapping additional Baseline ASCII TIFF Tags (Artist, Make, Model, ImageDescription & Copyright) to an ASCII data type which allows them to be written into GeoTIFFs per #430
Tested and tags are now written successfully when supplied in metadata object to
writeArrayBuffer().