Use dynamic imports for non-browser-compatible modules #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Iván Sánchez Ortega <[email protected]>
Signed-off-by: Iván Sánchez Ortega <[email protected]>
Side effect of the xml-utils changes - apparently babel tries to jump in and polyfill stuff. Signed-off-by: Iván Sánchez Ortega <[email protected]>
Signed-off-by: Iván Sánchez Ortega <[email protected]>
Signed-off-by: Iván Sánchez Ortega <[email protected]>
|
Thanks @IvanSanchez for providing this. This was always a thorn in my side (having to reference modules not available for the browser). Unfortunately, I'm too far removed from the current state of the art in terms of bundling. @ahocevar I think you were the one who introduced rollup in the build process. Do you think this change is reasonable? |
ahocevar
approved these changes
Mar 13, 2024
|
@IvanSanchez , I've promoted your changes for xml-utils from a release candidate to a minor release (along with some upgraded dependencies). If you like, you can use v1.8.0 of xml-utils in this PR now: https://github.com/DanielJDufour/xml-utils/releases/tag/v1.8.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit of background: I'm at the Évora OGC-OSGeo-ASF codesprint, trying to get multiband rasters work with gleo via geotiff.js. I wrote gleo so that it worked as native browser ESM modules, via
<script type='module'>andimportmap. See e.g. https://gitlab.com/IvanSanchez/gleo/-/blob/master/browser-demos/91-offscreen-indicator.html?ref_type=heads#L19-L40The problems that turn up when trying to run geotiff.js as native ESM modules are pretty much the sames as #411 - a file like
sources/remote.jsunconditionally imports the browser-compatible and the browser-incompatible files (i.e. a file withimport from 'fs'orimport from 'http'will crash in a browser).The approach of this fix is to conditionally load those troublesome modules, using dynamic imports. It still works the same, just with a couple more
asynccalls.See also DanielJDufour/xml-utils#7