#9018: Dashboard - Zoom in/out on maps connected to a 3D map #10460
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes fixing the inconsistently issue of zoom in/out that happens in 3d map sync with another map [2d or 3d].
The issue in 3D maps was that
dependenciesToMapProp.js
file updatescenter
andzoom
for map object into widgets state for the synced maps, and due that update_updateMapPositionFromNewProps
method into Map.js of cesium is called to update the map view.The issue was in these lines:
MapStore2/web/client/components/map/cesium/Map.jsx
Lines 504 to 511 in 2d097ff
It does not take the new props of center that was updated within
dependenciesToMapProp
as mentioned above.I have added 2 enhancements:
MapStore2/web/client/components/map/cesium/Map.jsx
Line 489 in 2d097ff
as during test I tried to move from a point with negative coordinates to a point with positive coordinates and vice versa so if the result with negative value, the logic of
isNearlyEqual
will not be accurate as expected.Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#9018
What is the current behavior?
#9018
What is the new behavior?
Now the zoom restriction that seems in the issue is fixed
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information