Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10455 Allow use of node version 20 #10457

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

allyoucanmap
Copy link
Contributor

@allyoucanmap allyoucanmap commented Jul 4, 2024

Description

This PR adds the node-options=--openssl-legacy-provider variable to the .npmrc files to use node version 20.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Minor changes to existing features

Issue

What is the current behavior?

#10455

What is the new behavior?

It is possible to install, run and compile mapstore with node version 20

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes

Other useful information

@allyoucanmap allyoucanmap added this to the 2024.02.00 milestone Jul 4, 2024
@allyoucanmap allyoucanmap self-assigned this Jul 4, 2024
@allyoucanmap allyoucanmap linked an issue Jul 4, 2024 that may be closed by this pull request
1 task
@tdipisa tdipisa requested a review from offtherailz July 4, 2024 12:29
@allyoucanmap
Copy link
Contributor Author

@tdipisa @offtherailz unfortunately it's not working without updating also the github actions.
We should also document someway this update but I'm not sure the migration guidelines is the right place

Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the documentation with this commit on the PR
Note @tdipisa and @allyoucanmap This is a breaking change. When this PR is merged, the application will not be able to build anymore with current version of node used.
I didn't found any workaround except to update the dependencies.
We can merge this PR and update all our CI/CD (e.g. jenkins) chain for this breaking change. Also projects, when updated, will need this upgrade of node version.

As an alternative we should identfy what libraries need this update, and evaluate the cost of the upate.

Please @allyoucanmap and @tdipisa let's check this and, before merging this PR, be aware of the changes needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow use of node version 20
2 participants