Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10448 Map plugin should not initizialize invalid maps #10449

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

allyoucanmap
Copy link
Contributor

Description

This PR includes following fixes:

  • add a validation check for map configuration in Map plugin
  • remove canRender internal state from the Map plugins because it's not used anymore, it was introduced for font loading

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Minor changes to existing features

Issue

What is the current behavior?

#10448

What is the new behavior?

Map plugin components mount only when a valid configuration is provided

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

Other useful information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map plugin should not initizialize invalid maps
2 participants