Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visibility limits - The resolution option is not retained as Limits type #10391

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Igi-ID
Copy link
Contributor

@Igi-ID Igi-ID commented May 31, 2024

Description

This PR fixes the limitsType persistence in client/components/TOC/fragments/settings/VisibilityLimitsForm.jsx. User-set settings for scale / resolution on an individual layer will now be saved across time.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?

#10355

What is the new behavior?
Resolution / scale settings are persisted on a layer individual basis.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@Igi-ID Igi-ID added this to the 2024.01.02 milestone May 31, 2024
@Igi-ID Igi-ID self-assigned this May 31, 2024
@Igi-ID Igi-ID linked an issue May 31, 2024 that may be closed by this pull request
1 task
@tdipisa tdipisa requested review from dsuren1 and removed request for offtherailz and tdipisa June 3, 2024 16:09
Copy link
Contributor

@dsuren1 dsuren1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Igi-ID
The limit type is not persisted on map save. I think it should be saved too, to avoid varying limit type value between saves

@tdipisa tdipisa assigned dsuren1 and unassigned Igi-ID Jun 10, 2024
@tdipisa tdipisa modified the milestones: 2024.01.02, 2024.02.00 Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visibility limits - The revolution option is not retained as Limits type
3 participants