#10026: Interactive legend for TOC layers [Vector layer part] #10188
Conversation
…r part] - Adding interactive legend for vector layers - Add checkbox for enable the interactive legend for wfs and vector into layer settings and for the catalog as well [just for wfs] - handle the logic of filter by legend for vector layer in case of 2d openlayer map and 3d cesium map - write unit tests based on code changes
mahmoudadel54
added
investigation
New Feature
There was a problem hiding this comment.
This PR contains outdated code that was removed and improved inside the work done for #10180, #10249 and #10426.
The mentioned outdated code refers to the LAYER_FILTER_BY_LEGEND and RESET_LAYER_FILTER_BY_LEGEND actions and related implementations including epics.
Apart from the outdated code also the general filter approach on the Vector and WFS layers should be reviewed and implemented separately.
Note that WFS layers currently apply CQL to a new request every time the layerFilter is updated, this could work for the QueryPanel but it could be a problem with legend because we will trigger a request every time we select a legend item. If possible both vector and wfs should be filtered client side.
Here a list of requirements needed for this implemenentation to discuss:
- Include the support of style filter in the filter system. This should be a new type to add as we have cql one and not the
parseGeoStylerFilterToCqlfunction. A user should be able to add an new format object to layerFilter as { format: 'style', body: [ ...style filter here ] } (format name TBD) - VectorLegend component needs to support the on click action adding the filter value as is to layerFilter with id
- All implementation of WFS layer OpenLayers, Cesium and Leaflet should implement a way to filter the data, using CQL is the current one but it would be interesting to apply filter client side
- All implementation of Vector layer OpenLayers, Cesium and Leaflet should implement a way to filter the data client side using the layer filter
Description
In this PR, interactive legend functionality for WMS/WFS layers is implemented. User can configure enabling the interactive legend for vector layer from display tab in layer settings. Legend filter will be reset if user change the style and user can reset it manually by clicking on the selected filter legend again to remove the legend filter.
This PR includes:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#10026
What is the current behavior?
#10026
What is the new behavior?
User can add vector layer and enable the interactive legend to enable him/her to filter the layer if user change style that includes filter expressions like classification style for example.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information