#10005 update babel configuration #10006
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: in order to make this PR build correctly, we need to publish eslint node lib. I didn't do it yet.
As explained in 10005 updating babel needs to update eslint too, and this causes several lint error because of old bugs of eslint not revealing the failing parts.
Here I attach the full set of errors.
eslint-errors.txt
The errors can be divided in 2 macro-blocks:
componentDidMount
)For this reason I propose the following:
We can evaluate to re-introduce the rule of proptypes later and fix the pending eslint errors disabled, but this way we guarantee:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
Fix #10005
What is the new behavior?
Babel updated. Eslint rule catch now finds errors that was not visible before.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
I also fixes some require/exports to avoid some lint errors too.
I noticed babel plugin
plugin-proposal-class-properties
is deprecated and we should useplugin-transform-class-properties
instead.I didn't do this update in this PR, concentrating the effort to a working solution.