-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): Add support for geoparquet reading #247
base: main
Are you sure you want to change the base?
Conversation
Hello! I am new to rust and georust community and I did not find any contribution guidelines, so please let me know if anything can be improved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks perfect! Indeed the RecordBatchReader
is the right option; I should've suggested that previously.
I'm hoping to release geoarrow 0.4 within a couple weeks, but I don't expect it to change much from the latest beta, and certainly not any of these APIs.
@@ -88,6 +91,26 @@ async fn transform<P: FeatureProcessor>(args: Cli, processor: &mut P) -> Result< | |||
Some("jsonl") | Some("geojsonl") => { | |||
GeozeroDatasource::process(&mut GeoJsonLineReader::new(filein), processor) | |||
} | |||
Some("parquet") | Some("geoparquet") => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The community discourages against .geoparquet
as a file extension, but I figure it's fine to accept files with the suffix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not have a strong opinion here, and tried to be consistent with json
/geojson
and also with stacrs
CLI which also supported both.
Note that due to compiler regressions: geoarrow/geoarrow-rs#716, rust-lang/rust#128887, rust-lang/rust#131960 this will fail to compile with
to install from this branch |
geoarrow/geoarrow-rs#956 works around the compiler regression, so the next release of |
I published geoarrow 0.4.0-beta.3 (https://crates.io/crates/geoarrow/0.4.0-beta.3) which lets you build without the nightly API. You can test out that beta release if you'd like. I'll publish geoarrow 0.4 in early January. It might be simplest to wait to merge this PR until then |
Add support for reading geoparquet files in the CLI.
Closes #242
There is additional discussion and pointers in the linked ticket.